Bluetooth: host: Replace length check assert with if statement #63605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlescufi
requested review from
alwa-nordic,
jhedberg,
Vudentz and
sjanc
as code owners
carlescufi
requested review from
Thalley,
cvinayak,
alwa-nordic,
jori-nordic,
theob-pro and
jhedberg
and removed request for
jhedberg,
Vudentz,
sjanc and
alwa-nordic
zephyrbot
added
area: Bluetooth
area: Bluetooth Host
zephyrbot
requested review from
asbjornsabo,
hermabe,
kruithofa,
sjanc and
Vudentz
jori-nordic
previously approved these changes
Oct 6, 2023
Thalley
reviewed
Oct 6, 2023
carlescufi
force-pushed
the
hci-assert-to-if
branch
from
3d78d1b to
7577914
Compare
cvinayak
previously approved these changes
Oct 6, 2023
jhedberg
previously approved these changes
Oct 6, 2023
A few of the length checks that deal with HCI packets coming from the controller were using assert statements. But the recommended practice is to drop invalid packets and continue execution whenever a malformed packet arrives from an external source, so replace those assert statements with branches that will drop the packet and return. Signed-off-by: Carles Cufi <[email protected]>
carlescufi
dismissed stale reviews from jhedberg, cvinayak, and jori-nordic
via
8bcda7c
carlescufi
force-pushed
the
hci-assert-to-if
branch
from
7577914 to
8bcda7c
Compare
|
@Thalley please take another look |
Thalley
approved these changes
Oct 6, 2023
cvinayak
approved these changes
Oct 6, 2023
jhedberg
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few of the length checks that deal with HCI packets coming from the controller were using assert statements. But the recommended practice is to drop invalid packets and continue execution whenever a malformed packet arrives from an external source, so replace those assert statements with branches that will drop the packet and return.