Bluetooth: Mesh: FU Server should not update internal state on error #64258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omkar3141
requested review from
jhedberg,
PavelVPV,
Vudentz and
LingaoM
as code owners
omkar3141
requested review from
ludvigsj,
alxelax,
akredalen and
m-alperen-sener
PavelVPV
previously approved these changes
Oct 23, 2023
alxelax
reviewed
Oct 23, 2023
|
PTS logs run from Alperen's local server: |
Andrewpini
previously approved these changes
Oct 23, 2023
omkar3141
force-pushed
the
bugfix/dfu_dont_update_internal_state_when_ideompotency_check_fails2
branch
from
4eb4017 to
c2106f7
Compare
|
Based on internal tests, all DFU/SR/FD/* and DFU/SR/FU* tests pass for commit b4eef4d. |
According to conditions in the DFU spec section 6.1.3.7 (Sending a Firmware Update Status message) and in 'Idempotency' part of section 6.1.3.4 (Receiving a Firmware Update Start message), the FU Server should not update internal state when 'Wrong Phase' error condition is triggered. Signed-off-by: Omkar Kulkarni <[email protected]>
omkar3141
force-pushed
the
bugfix/dfu_dont_update_internal_state_when_ideompotency_check_fails2
branch
from
c2106f7 to
b4eef4d
Compare
m-alperen-sener
pushed a commit
to m-alperen-sener/sdk-zephyr
that referenced
this pull request
Oct 23, 2023
…state on error According to conditions in the DFU spec section 6.1.3.7 (Sending a Firmware Update Status message) and in 'Idempotency' part of section 6.1.3.4 (Receiving a Firmware Update Start message), the FU Server should not update internal state when 'Wrong Phase' error condition is triggered. Upstream PR: zephyrproject-rtos/zephyr#64258 Signed-off-by: Omkar Kulkarni <[email protected]> (cherry picked from commit b4eef4da68a5c1f4b02c4d10ee0340375f775a14)
PavelVPV
approved these changes
Oct 23, 2023
alxelax
approved these changes
Oct 23, 2023
cvinayak
pushed a commit
to nrfconnect/sdk-zephyr
that referenced
this pull request
Oct 23, 2023
…state on error According to conditions in the DFU spec section 6.1.3.7 (Sending a Firmware Update Status message) and in 'Idempotency' part of section 6.1.3.4 (Receiving a Firmware Update Start message), the FU Server should not update internal state when 'Wrong Phase' error condition is triggered. Upstream PR: zephyrproject-rtos/zephyr#64258 Signed-off-by: Omkar Kulkarni <[email protected]> (cherry picked from commit b4eef4da68a5c1f4b02c4d10ee0340375f775a14)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to conditions in the DFU spec section 6.1.3.7 (Sending a Firmware Update Status message) and in 'Idempotency' part of section 6.1.3.4 (Receiving a Firmware Update Start message), the FU Server should not update internal state when 'Wrong Phase' error condition is triggered.