drivers: can: be consistent in filter_id checks when removing rx filters #64399
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change the CAN controller driver implementations for the can_remove_rx_filter() API call to be consistent in their validation of the supplied filter_id. Fixes: zephyrproject-rtos#64398 Signed-off-by: Henrik Brix Andersen <[email protected]>
henrikbrixandersen
requested review from
aaillet,
karstenkoenig and
alexanderwachter
as code owners
zephyrbot
added
platform: Renesas R-Car
zephyrbot
requested review from
bperseghetti,
danieldegrasse,
decsny,
DerekSnell,
dleach02,
EmilioCBen,
manuargue,
martinjaeger,
mmahadevan108,
PetervdPerk-NXP,
str4t0m and
yvanderv
martinjaeger
approved these changes
Oct 26, 2023
bjarki-andreasen
approved these changes
Oct 26, 2023
This was referenced Oct 26, 2023
mathieuchopstm
pushed a commit
to mathieuchopstm/zephyr
that referenced
this pull request
Feb 23, 2024
PR zephyrproject-rtos#64399 introduced checks for out-of-bounds filter IDs in CAN drivers, along with logging of said IDs; however, the call to LOG_ERR in the native POSIX/Linux driver is missing the 'filter_id' argument. This commit adds the missing argument to ensure proper data is printed when the LOG_ERR call is performed. Signed-off-by: Mathieu Choplain <[email protected]>
nashif
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR #64399 introduced checks for out-of-bounds filter IDs in CAN drivers, along with logging of said IDs; however, the call to LOG_ERR in the native POSIX/Linux driver is missing the 'filter_id' argument. This commit adds the missing argument to ensure proper data is printed when the LOG_ERR call is performed. Signed-off-by: Mathieu Choplain <[email protected]>
zephyrbot
pushed a commit
that referenced
this pull request
Feb 26, 2024
PR #64399 introduced checks for out-of-bounds filter IDs in CAN drivers, along with logging of said IDs; however, the call to LOG_ERR in the native POSIX/Linux driver is missing the 'filter_id' argument. This commit adds the missing argument to ensure proper data is printed when the LOG_ERR call is performed. Signed-off-by: Mathieu Choplain <[email protected]> (cherry picked from commit 6ff47b1)
henrikbrixandersen
pushed a commit
that referenced
this pull request
Mar 5, 2024
PR #64399 introduced checks for out-of-bounds filter IDs in CAN drivers, along with logging of said IDs; however, the call to LOG_ERR in the native POSIX/Linux driver is missing the 'filter_id' argument. This commit adds the missing argument to ensure proper data is printed when the LOG_ERR call is performed. Signed-off-by: Mathieu Choplain <[email protected]> (cherry picked from commit 6ff47b1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the CAN controller driver implementations for the
can_remove_rx_filter()API call to be consistent in their validation of the suppliedfilter_id.Fixes: #64398