Bluetooth: GATT: Add missing LESC_MASK for encrypt check #69170
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The LE Secure connection (LESC) mask also require encryption, and some users have been using e.g. BT_GATT_PERM_READ_LESC without BT_GATT_PERM_READ_ENCRYPT, and then the encryption check in bt_gatt_check_perm was never properly applied. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
gatt_lesc_check
branch
2 times, most recently
from
6c22ddb to
1c7c4bb
Compare
The test where it was supposed to read the long characteristic, only read the "small" characteristic, due to setting the wrong handle. With the right handle, the test failed and the test had to be updated to store the data across multiple reads, and then do the proper comparison. Signed-off-by: Emil Gydesen <[email protected]>
Add tests for the GATT permissions to read and write for characteristics that require encryption and LESC encryption. Signed-off-by: Emil Gydesen <[email protected]>
Thalley
force-pushed
the
gatt_lesc_check
branch
from
1c7c4bb to
e5fae45
Compare
zephyrbot
added
area: Bluetooth Host
zephyrbot
requested review from
alwa-nordic,
hermabe,
jhedberg,
jori-nordic,
sjanc and
theob-pro
alwa-nordic
approved these changes
Feb 19, 2024
thedjnK
approved these changes
Feb 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The LE Secure connection (LESC) mask also require encryption, and some users have been using e.g. BT_GATT_PERM_READ_LESC without BT_GATT_PERM_READ_ENCRYPT, and then the encryption check in bt_gatt_check_perm was never properly applied.