Skip to content

Conversation

ekleezg
Copy link
Contributor

@ekleezg ekleezg commented Jun 14, 2024

Added a check for the length of user input as it was missing.

Copy link

Hello @ekleezg, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@jhedberg
Copy link
Member

@ekleezg thanks, but no need to split these into multiple commits since they're all quite related to each other. Just squash the changes into a single commit and force push. Also add a commit message body (i.e. some additional text than just the commit subject), since the Compliance CI check will otherwise fail.

@ekleezg ekleezg force-pushed the bt_classic_length_check branch from 1a778e1 to 4fffdee Compare June 14, 2024 08:41
@ekleezg ekleezg force-pushed the bt_classic_length_check branch from 4fffdee to bbfd9c0 Compare June 14, 2024 10:13
@kartben
Copy link
Contributor

kartben commented Jun 14, 2024

@ekleezg you need to amend your git commit author name/email so that it matches the sign-off entry. Thanks!

Added length checks for user input in `sdp_client_receive` and
`l2cap_br_info_rsp`.

Signed-off-by: Eunkyu Lee <[email protected]>
@ekleezg ekleezg force-pushed the bt_classic_length_check branch from bbfd9c0 to 4133127 Compare June 14, 2024 16:35
@ekleezg
Copy link
Contributor Author

ekleezg commented Jun 14, 2024

Thank you for let me know. I changed it.

@kartben kartben assigned lylezhu2012 and unassigned jori-nordic Jun 14, 2024
@nashif nashif added this to the v3.7.0 milestone Jun 18, 2024
@aescolar aescolar merged commit 8888125 into zephyrproject-rtos:main Jun 18, 2024
Copy link

Hi @ekleezg!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: Bluetooth Classic Bluetooth Classic (BR/EDR) area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants