DNS parsing issues #82072
Merged
DNS parsing issues #82072
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the packet parsing fails in dns_unpack_response_query(), then do not continue further but bail out early. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure we test malformed packet parsing. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure that when copying the qname, the source buffer is large enough for the data. Signed-off-by: Jukka Rissanen <[email protected]>
The dns_unpack_answer() did not check the length of the message properly which can cause out of bounds read. Signed-off-by: Jukka Rissanen <[email protected]>
Make sure we catch invalid answer during parsing. Signed-off-by: Jukka Rissanen <[email protected]>
jukkar
force-pushed
the
fix/dns-parsing-issues
branch
from
a497464 to
40f7359
Compare
pdgendt
approved these changes
Nov 26, 2024
rlubos
approved these changes
Nov 26, 2024
jukkar
added
backport v2.7-branch
backport v3.7-branch
Closed
This was referenced Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes couple of DNS parsing issues. There are also tests created to catch these when applicable.
Fixes #82139