-
-
Notifications
You must be signed in to change notification settings - Fork 395
Move away from virtualenv #625
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I'll just add a note that while |
I hope this issue is open to work @showell. Can you please add some labels that would allow me to claim the issue. |
@zulipbot claim |
Hello @LoopThrough-i-j! Thanks for your interest in Zulip! You have attempted to claim an issue without the labels "help wanted", "good first issue". Since you're a new contributor, you can only claim and submit pull requests for issues with the help wanted or good first issue labels. If this is your first time here, we recommend reading our guide for new contributors before getting started. |
@QEDK, @showell and @neiljp I tested venv on WSL and everything felt nice and smooth. Not sure of the issue @QEDK is talking about. I insatlled windows to test everything out. Probably @QEDK made some irregular sudo usage that could have broken |
You missed what I said on Zulip, it needs to be the Windows filesystem inside WSL. I know to not use |
@QEDK yeah, I understand and am trying things out. I wrote this comment before checking for the chat, sorry for that. |
It's totally cool, I'm just explaining why it's an issue. I've replied on
Zulip more thoroughly.
…On Sat, 23 Jan, 2021, 18:11 Debayan Ganguly, ***@***.***> wrote:
@QEDK <https://github.com/QEDK> yeah, I understand and am trying things
out. I wrote this comment before checking for the chat, sorry for that.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#625 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAJWRQQT5YPLDV52OLTZ4ZDS3K7ZBANCNFSM4RW6WIUA>
.
|
Hello @LoopThrough-i-j, you claimed this issue to work on it, but this issue and any referenced pull requests haven't been updated for 10 days. Are you still working on this issue? If so, please update this issue by leaving a comment on this issue to let me know that you're still working on it. Otherwise, I'll automatically remove you from this issue in 4 days. If you've decided to work on something else, simply comment Thank you for your valuable contributions to Zulip! |
@rht would you mind taking a look at the PR |
Fixes zulip#625 Changes: - Replace virtualenv, to python native venv. The venv used is native to python3 and need not be shipped separately on any OS other than Ubuntu/Debian. - Remove redundant activation script. An activation script is required to use the pip and python in the virtual environment, but in case the path to the pip is mentioned, pip takes care of installing the packages in the environment where pip is located.
- Replace virtualenv with python 3's native venv feature. The venv used is native to python3.5+, so there's no need for a separate dependency. - Remove redundant activation script. An activation script is required to use the pip and python in the virtual environment, but because we're calling the pip inside the venv, we don't need one. Fixes #625.
Since python3.5, the recommended methodology for creating virtual environments is to use the native venv module.
Now that we no longer support older versions of python, we no longer need virtualenv.
More discussion here: https://chat.zulip.org/#narrow/stream/2-general/topic/page.20not.20found/near/1022651
The text was updated successfully, but these errors were encountered: