Skip to content

Provision: Replace virtualenv by python native venv. #646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 25, 2021
Merged

Provision: Replace virtualenv by python native venv. #646

merged 1 commit into from
Feb 25, 2021

Conversation

LoopThrough-i-j
Copy link
Contributor

@LoopThrough-i-j LoopThrough-i-j commented Jan 27, 2021 •
edited
Loading

Fixes #625

LoopThrough-i-j
LoopThrough-i-j commented Jan 27, 2021
View reviewed changes
Copy link
Contributor Author

@LoopThrough-i-j LoopThrough-i-j left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure about this line for venv. Can anyone help?

rht
rht reviewed Feb 7, 2021
View reviewed changes
rht
rht reviewed Feb 7, 2021
View reviewed changes
rht
rht reviewed Feb 7, 2021
View reviewed changes
@LoopThrough-i-j LoopThrough-i-j force-pushed the VirtualenvToVenv branch 2 times, most recently from 60a638a to 499ea0e Compare February 8, 2021 15:42
rht
rht reviewed Feb 11, 2021
View reviewed changes
@LoopThrough-i-j LoopThrough-i-j force-pushed the VirtualenvToVenv branch 2 times, most recently from 93b17ab to 866b90e Compare February 25, 2021 01:07
@LoopThrough-i-j
provision: Replace virtualenv by python native venv.
22c33c3 
Fixes zulip#625
Changes:
- Replace virtualenv, to python native venv. The venv used is native to
  python3 and need not be shipped separately on any OS other than
  Ubuntu/Debian.
- Remove redundant activation script. An activation script is required
  to use the pip and python in the virtual environment, but in case
  the path to the pip is mentioned, pip takes care of installing the
  packages in the environment where pip is located.
@timabbott timabbott merged commit 6ac2165 into zulip:master Feb 25, 2021
@timabbott
Copy link
Member

timabbott commented Feb 25, 2021 •
edited
Loading

Merged, thanks @LoopThrough-i-j! I made a few edits to the commit message, mainly for technical English ("Replace virtualenv with python native venv.", i.e. I did s/by/with/).

Also to move the Fixes line to the end of the commit message.
Check out the Zulip commit message guidelines for more details: https://zulip.readthedocs.io/en/latest/contributing/version-control.html#commit-messages

@LoopThrough-i-j
Copy link
Contributor Author

Thanks, will keep it in mind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht left review comments

Assignees
No one assigned
Labels
size: M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move away from virtualenv
4 participants
@LoopThrough-i-j @timabbott @rht @zulipbot