-
Notifications
You must be signed in to change notification settings - Fork 306
Sibling layout interactions in content, like p+ul
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@karlstolley writes last week that he'll be working soon on cleaning up that CSS, simplifying things. (For example, that rule about So this task should become simpler after that work is complete. |
Some details here: In particular one planned simplification is:
(whereas the status quo involves |
Another rule with a similar character, about an absence-of-sibling rather than siblings, is the one with /* Headings */
& h1,
h2,
h3,
h4,
h5,
h6 {
// …
margin-top: 15px;
// …
}
/* Headings: Ensure that messages that start with a heading don't have
a weirdly blank area at the very start of the message. */
& h1:first-child,
h2:first-child,
h3:first-child,
h4:first-child,
h5:first-child,
h6:first-child {
margin-top: 0;
} As @sirpengi points out at #492, we don't yet implement that rule either. Probably we should consider it as part of this issue. |
My hope with headings is that presenting them with a generous line-height will obviate the need for additional |
Zulip web has a couple of CSS rules that adjust spacing between sibling block elements. From
web/styles/rendered_markdown.css
:(The details have changed occasionally over the years, as in zulip/zulip@d7aa186 and
zulip/zulip@62f2396.)
We should either match that behavior, or determine there's a good reason for mobile to differ from web here.
The text was updated successfully, but these errors were encountered: