Edit-message (8/n): Add/use prevContentSha256 param #1496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisbobbe
force-pushed
the
pr-edit-message-8
branch
from
4338003 to
e5dcfff
Compare
chrisbobbe
force-pushed
the
pr-edit-message-8
branch
from
e5dcfff to
9cb1334
Compare
|
Rebased now that #1484 has been merged. |
gnprice
reviewed
May 2, 2025
test/model/message_test.dart
Outdated
Comment on lines
159
to
161
| originalRawContent: 'old content', newContent: 'new content'); | ||
| checkRequest(message.id, | ||
| prevContentSha256: '34a780ad578b997db55b260beb60b501f3e04d30ba1a51fcf43cd8dd1241780d', |
There was a problem hiding this comment.
Presumably this is the hash of the string "old content"? Probably clearest to say it that way directly. (The computing of the hash can get centralized into this checkRequest helper.)
chrisbobbe
force-pushed
the
pr-edit-message-8
branch
from
9cb1334 to
6ff20f6
Compare
|
Thanks! Revision pushed. |
|
Thanks! Looks good; merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.