Skip to content

fix(cloud-databases): Refactor tests Part 1 #5810

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

lornakelly
Copy link
Contributor

@lornakelly lornakelly commented Nov 22, 2024

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for pull request followers and do not help prioritize the request

Ticket: https://github.ibm.com/compose/App/issues/1412

Refactoring acceptance tests is time consuming as running the tests takes a long time so refactoring bit by bit

  • Removed common test functions into new file and out of PG file
  • concatenate PG PITR test

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccIBMDatabaseInstancePostgresPITR'
=== RUN   TestAccIBMDatabaseInstancePostgresPITR
=== PAUSE TestAccIBMDatabaseInstancePostgresPITR
=== CONT  TestAccIBMDatabaseInstancePostgresPITR
--- PASS: TestAccIBMDatabaseInstancePostgresPITR (1266.04s)
PASS
ok      github.com/IBM-Cloud/terraform-provider-ibm/ibm/service/database        1270.265s
...

Copy link
Collaborator

@omaraibrahim omaraibrahim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lornakelly lornakelly changed the title Refactor tests Part 1 fix(cloud-databases): Refactor tests Part 1 Nov 22, 2024
@omaraibrahim omaraibrahim merged commit 02ddca6 into IBM-Cloud:master Nov 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants