Skip to content

Deduplicate uniqueness prefixes #793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2023

Conversation

ltrzesniewski
Copy link
Contributor

@ltrzesniewski ltrzesniewski commented Feb 18, 2023

I had a case where file names had duplicate uniqueness prefixes (as I described here), such as:

AssemblyToProcess.BasicTestCases.HandleExceptionBlocks.DotNet7_0.Release.DotNet7_0.received.il

Which is caused by the following code (when used with this config):

if (namer.ResolveUniqueForRuntimeAndVersion() ||
TargetAssembly.TargetsMultipleFramework)
{
sharedUniqueness.Add(Namer.RuntimeAndVersion);
}

This proposed fix makes sure the prefixes are distinct.

I'm not sure why the received ans verified file prefixes aren't necessarily equal, but this seems to confuse the tools I use.

@SimonCropp SimonCropp added this to the 19.10.0 milestone Feb 19, 2023
@SimonCropp SimonCropp merged commit aa2df5b into VerifyTests:main Feb 19, 2023
@SimonCropp SimonCropp added the Bug label Feb 19, 2023
@ltrzesniewski ltrzesniewski deleted the distinct-uniqueness-list branch February 19, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants