fix(compiler-cli): only bind inputs that are part of microsyntax to a structural directive #52453
+52
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoostK
added
target: patch
JoostK
added
the
action: review
JoostK
force-pushed
the
ngtsc/ttc/tmpl-bindings
branch
from
c2e9826 to
1c63c6c
Compare
JoostK
force-pushed
the
ngtsc/ttc/tmpl-bindings
branch
2 times, most recently
from
705ef0f to
dc3ce91
Compare
JoostK
force-pushed
the
ngtsc/ttc/tmpl-bindings
branch
from
dc3ce91 to
ba9865b
Compare
angular-robot
bot
removed
the
area: compiler
JoostK
added
the
area: compiler
Closed
14 tasks
|
Hey @JoostK. Should we land this? |
Yes, I'd think so as it fixes a reported bug. Let me rebase during the coming days 👍 |
JoostK
added
action: cleanup
… structural directive Prior to this change the template type-check generator would incorrectly apply inputs and attributes to a structural directive, where only the bindings as present in microsyntax are actually bound to the directive. This introduced a problem where usages of template variables could not be resolved, because the template variables are out-of-scope of the template element itself. Closes angular#49931
JoostK
force-pushed
the
ngtsc/ttc/tmpl-bindings
branch
from
ba9865b to
1c89c45
Compare
thePunderWoman
removed
the
action: cleanup
thePunderWoman
added
the
action: merge
thePunderWoman
pushed a commit
that referenced
this pull request
Sep 17, 2025
… structural directive (#52453) Prior to this change the template type-check generator would incorrectly apply inputs and attributes to a structural directive, where only the bindings as present in microsyntax are actually bound to the directive. This introduced a problem where usages of template variables could not be resolved, because the template variables are out-of-scope of the template element itself. Closes #49931 PR Close #52453
wildcardalice
pushed a commit
to wildcardalice/angular
that referenced
this pull request
Sep 18, 2025
… structural directive (angular#52453) Prior to this change the template type-check generator would incorrectly apply inputs and attributes to a structural directive, where only the bindings as present in microsyntax are actually bound to the directive. This introduced a problem where usages of template variables could not be resolved, because the template variables are out-of-scope of the template element itself. Closes angular#49931 PR Close angular#52453
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change the template type-check generator would incorrectly apply inputs and attributes to a structural directive, where only the bindings as present in microsyntax are actually bound to the directive. This introduced a problem where usages of template variables could not be resolved, because the template variables are out-of-scope of the template element itself.
Closes #49931