fix(core): handle cases where classes added have no animations #63242
+192
−87
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thePunderWoman
added
action: review
thePunderWoman
force-pushed
the
empty-animate
branch
from
42c0804 to
bb33946
Compare
JeanMeche
reviewed
Aug 19, 2025
thePunderWoman
force-pushed
the
empty-animate
branch
from
bb33946 to
2c90cbc
Compare
JeanMeche
reviewed
Aug 19, 2025
thePunderWoman
force-pushed
the
empty-animate
branch
from
2c90cbc to
c11da3c
Compare
crisbeto
approved these changes
Aug 20, 2025
thePunderWoman
added
action: merge
JeanMeche
reviewed
Aug 20, 2025
In the case that someone wants to disable animations via selector specificity, for example by adding an `.animate-disabled` class to a parent node, we need to make sure the animate instructions don't misbehave. Now we detect if animations exist in the provided classes and react accordingly. fixes: angular#63161
thePunderWoman
force-pushed
the
empty-animate
branch
from
c11da3c to
8564d8e
Compare
thePunderWoman
added a commit
that referenced
this pull request
Aug 20, 2025
In the case that someone wants to disable animations via selector specificity, for example by adding an `.animate-disabled` class to a parent node, we need to make sure the animate instructions don't misbehave. Now we detect if animations exist in the provided classes and react accordingly. fixes: #63161 PR Close #63242
|
This PR was merged into the repository by commit 70afb41. The changes were merged into the following branches: main, 20.2.x |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case that someone wants to disable animations via selector specificity, for example by adding an
.animate-disabledclass to a parent node, we need to make sure the animate instructions don't misbehave. Now we detect if animations exist in the provided classes and react accordingly.fixes: #63161
Does this PR introduce a breaking change?