-
Notifications
You must be signed in to change notification settings - Fork 915
feat(wrangler): DX optimisations in wrangler dev --remote
#7425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e849ab5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
packages/wrangler/src/api/startDevWorker/RemoteRuntimeController.ts
Outdated
Show resolved
Hide resolved
34022c7
to
e1c8f30
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-wrangler-7425 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7425/npm-package-wrangler-7425 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-wrangler-7425 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-bindings-extension-7425 -O ./cloudflare-workers-bindings-extension.0.0.0-vab01249e3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vab01249e3.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-create-cloudflare-7425 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-kv-asset-handler-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-miniflare-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-pages-shared-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-unenv-preset-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-vitest-pool-workers-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-editor-shared-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workers-shared-7425 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409630032/npm-package-cloudflare-workflows-shared-7425 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
14b81d2
to
a1cd8fc
Compare
d98bc63
to
4fe76bb
Compare
Workers + Assets projects have, in certain situations, a relatively degraded `wrangler dev --remote` developer experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to make extra API calls to: 1. check for asset files changes 2. upload the changed assets, if any This commit improves the `wrangler dev --remote` DX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by the new changes.
4fe76bb
to
e849ab5
Compare
Workers + Assets projects have, in certain situations, a relatively degraded `wrangler dev --remote` developer experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to make extra API calls to: 1. check for asset files changes 2. upload the changed assets, if any This commit improves the `wrangler dev --remote` DX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by the new changes.
Fixes DEVX-1523
Workers + Assets projects have, in certain situations, a relatively degraded
wrangler dev --remote
developer experience, as opposed to Workers proper projects. This is due to the fact that, for Workers + Assets, we need to makeextra API calls to:
This commit improves the
wrangler dev --remote
DX for Workers + Assets, for use cases when the User Worker/assets change while the API calls for previous changes are still in flight. For such use cases, we have put an exit early strategy in place, that drops the event handler execution of the previous changes, in favour of the handler triggered by thenew changes.
For
before
/after
screenshots pls see DEVX-1523How these changes were tested
NOTE
Before

After

After

After
