Skip to content

chore(@commitlint/config-nx-scopes): add support for nx 18 #3895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

supernaut
Copy link

Description

Nx version 18 has been released and it does not break @commitlint/config-nx-scopes support.

Motivation and Context

After updating Nx to version 18 package managers throws a warning for unmet peer-dependencies for @commitlint/config-nx-scopes.

How Has This Been Tested?

@commitlint/config-nx-scopes still works as expected after updating Nx to version 18.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@eliasmohsengrenvald
Copy link

We're looking forward to this PR getting merged, may I ask what the status is?

@escapedcat
Copy link
Member

Ah sorry, merged #3896 but just saw it would remove all old versions which is stupid.
@supernaut would you mind rebasing this one and then we can merge it.
/cc @marcin-sieradzki-maersk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants