Skip to content

Fix length variable in via-(length:*) class being merged with via-<color> classes accidentally #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dcastil
Copy link
Owner

@dcastil dcastil commented Mar 31, 2025

Closes #557

@github-actions github-actions bot added context-v3 Related to tailwind-merge v3 bug Something isn't working labels Mar 31, 2025
Copy link

Metrics report

At head commit 7fd49e7 and base commit b7721dc at 2025-03-31T20:22:03.416Z

Size

Export Size original Size minified Size minified and Brotli compressed
tailwind-merge esm 83.99 kB 0.0% 🔴 22.45 kB 0.0% 🔴 6.28 kB +0.2% 🔴
 › extendTailwindMerge 83.29 kB 0.0% 🔴 21.82 kB 0.0% 🔴 6.08 kB +0.8% 🔴
 › getDefaultConfig 67.53 kB 0.0% 🔴 17.32 kB 0.0% 🔴 4.44 kB -0.9% 🟢
 › twMerge 80.97 kB 0.0% 🔴 20.97 kB 0.0% 🔴 5.84 kB -0.2% 🟢
tailwind-merge cjs 84.25 kB 0.0% 🔴 28.15 kB +0.1% 🔴 6.64 kB -0.3% 🟢
tailwind-merge/es5 esm 89.20 kB 0.0% 🔴 24.37 kB 0.0% 🔴 6.50 kB -0.1% 🟢
 › extendTailwindMerge 88.10 kB 0.0% 🔴 23.73 kB 0.0% 🔴 6.28 kB +0.5% 🔴
 › getDefaultConfig 69.90 kB 0.0% 🔴 18.43 kB 0.0% 🔴 4.54 kB -0.2% 🟢
 › twMerge 85.20 kB 0.0% 🔴 22.67 kB 0.0% 🔴 6.04 kB +0.2% 🔴
tailwind-merge/es5 cjs 89.46 kB 0.0% 🔴 30.09 kB +0.1% 🔴 6.85 kB -0.3% 🟢
All size metrics
Export Size original Size minified Size minified and Brotli compressed
tailwind-merge esm 83.99 kB 0.0% 🔴 22.45 kB 0.0% 🔴 6.28 kB +0.2% 🔴
 › createTailwindMerge 13.42 kB 0% 3.61 kB 0% 1.44 kB 0%
 › extendTailwindMerge 83.29 kB 0.0% 🔴 21.82 kB 0.0% 🔴 6.08 kB +0.8% 🔴
 › fromTheme 0.16 kB 0% 0.08 kB 0% 0.09 kB 0%
 › getDefaultConfig 67.53 kB 0.0% 🔴 17.32 kB 0.0% 🔴 4.44 kB -0.9% 🟢
 › mergeConfigs 2.12 kB 0% 0.80 kB 0% 0.27 kB 0%
 › twJoin 1.06 kB 0% 0.26 kB 0% 0.16 kB 0%
 › twMerge 80.97 kB 0.0% 🔴 20.97 kB 0.0% 🔴 5.84 kB -0.2% 🟢
 › validators 4.49 kB 0% 1.69 kB 0% 0.73 kB 0%
tailwind-merge cjs 84.25 kB 0.0% 🔴 28.15 kB +0.1% 🔴 6.64 kB -0.3% 🟢
tailwind-merge/es5 esm 89.20 kB 0.0% 🔴 24.37 kB 0.0% 🔴 6.50 kB -0.1% 🟢
 › createTailwindMerge 15.27 kB 0% 4.20 kB 0% 1.56 kB 0%
 › extendTailwindMerge 88.10 kB 0.0% 🔴 23.73 kB 0.0% 🔴 6.28 kB +0.5% 🔴
 › fromTheme 0.21 kB 0% 0.10 kB 0% 0.09 kB 0%
 › getDefaultConfig 69.90 kB 0.0% 🔴 18.43 kB 0.0% 🔴 4.54 kB -0.2% 🟢
 › mergeConfigs 2.46 kB 0% 0.87 kB 0% 0.29 kB 0%
 › twJoin 1.08 kB 0% 0.26 kB 0% 0.14 kB 0%
 › twMerge 85.20 kB 0.0% 🔴 22.67 kB 0.0% 🔴 6.04 kB +0.2% 🔴
 › validators 6.09 kB 0% 2.23 kB 0% 0.76 kB 0%
tailwind-merge/es5 cjs 89.46 kB 0.0% 🔴 30.09 kB +0.1% 🔴 6.85 kB -0.3% 🟢

Copy link

codspeed-hq bot commented Mar 31, 2025

CodSpeed Performance Report

Merging #559 will not alter performance

Comparing bugfix/557/fix-length-variable-in-via-class-not-being-detected (7fd49e7) with main (b7721dc)

Summary

✅ 5 untouched benchmarks

@dcastil dcastil merged commit 0f3ecff into main Mar 31, 2025
7 checks passed
@dcastil dcastil deleted the bugfix/557/fix-length-variable-in-via-class-not-being-detected branch March 31, 2025 20:23
Copy link

This was addressed in release v3.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working context-v3 Related to tailwind-merge v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrectly identifies via-(length:...) as a color
1 participant