fix(text): Improve sentence ending logic #1206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes ietf-tools#1205 This adds `a.k.a.` to list of strings that doesn't mark end of a sentence. This improves not sentence end text-chunk identification by identifying abbreviated chunks in `(a.k.a. Foo` or `[i.e. Bar` as not sentence ending text chunks.
rjsparks
reviewed
Jan 23, 2025
rjsparks
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1205
a.k.a.to list of strings that doesn't mark end of a sentence.(a.k.a. Fooor[i.e. Baras not sentence ending text chunks.e.g.to to list of strings that doesn't mark end of a sentence.