Implement new resolve algorithm #365
Conversation
|
|
||
| const pattern = new RegExp(stringPattern, 'u'); | ||
|
|
||
| return { pattern, suiteNames, message }; |
There was a problem hiding this comment.
The documentation still says suiteNames is available, and the changelog for 11.0.0 fails to mention this breaking change.
There was a problem hiding this comment.
It is still possible to define custom suiteNames via the plugin settings. It will be respected by all rules, so individual rules don’t have to define this.
There was a problem hiding this comment.
Still it was not mentioned anywhere. As in my project context() is not used in the same way as describe() is, it was excluded from the rule by specifying "describe" as the only key for suiteNames in the rule. By just removing the parameter I now have hundreds of warnings for that.
Simply removing this feature without mentioning it is quite annoying, as the plugin settings just allow for additionalCustomNames but not skipping existing one as possible before.
It would be great to have this documented somewhere. I've opened #403 about it. |
Breaking Changes:
no-skipped-testshas been removed, its functionality has been merged into the existingno-pending-testsrulemocha/additionalCustomNamesnow only allows to assign a custom name to exactly one interfacequnitinterfacehandle-done-callback: optionignoreSkippedhas been renamed toignorePendingvalid-suite-description: the rule option must always be an objectvalid-test-description: the rule option must always be an objectFeatures:
mocha/interface: when setting this toexports(default isBDD) then mocha function calls are resolved from import statements (e.g.import { it } from 'mocha';)const foo = it; foo.only('bar', () => {})is now correctly detected is usage ofit.only()Fixes: #363, #327, #264