Improve exported plugin type #400
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Define the mocha plugin with a meaningful shape, including supported config keys. Use satisfies operator to ensure the final plugin adheres to type `ESLint.Plugin`. This will fix type errors when users attempt to use `mochaPlugin.configs.recommended` (and `.all`) in type checked eslint configs. - Update test since `rules` is no longer possibly undefined.
Contributor
Author
|
@lo1tuma - Would you be willing to review? |
Apply satisfies operator during assignment, not export.
Contributor
Author
|
Or maybe @screendriver could review? |
screendriver
approved these changes
Oct 1, 2025
Contributor
|
@screendriver (or @lo1tuma) Please add the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESLint.Plugin. This will fix type errors when users attempt to usemochaPlugin.configs.recommended(and.all) in type checked eslint configs.rulesis no longer possibly undefined.Fixes #392