Skip to content

feat(angular): add convert-to-rspack generator #29860

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 14, 2025

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Feb 3, 2025

Current Behavior

Nx currently does not offer an automated method for switching from an Angular Webpack build to an Angular Rspack build.

Expected Behavior

Provide a generator convert-to-rspack in @nx/angular that will allow conversion from an Angular Webpack build to an Angular Rspack build.

Usage: nx g convert-to-rspack --project=myapp

TODO

  • handle more builder options
  • take existing custom webpack configs and migrate into the rspack config that is created

@Coly010 Coly010 self-assigned this Feb 3, 2025
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 14, 2025 4:38pm

Copy link

nx-cloud bot commented Feb 3, 2025

View your CI Pipeline Execution ↗ for commit 779db90.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 18m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=398ab... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-03-14 17:11:06 UTC

Copy link

github-actions bot commented Feb 4, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-43e1fcb
Release details 📑
Published version 0.0.0-pr-29860-43e1fcb
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 43e1fcb
Workflow run 13133852282

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

Copy link

Failed to publish a PR release of this pull request, triggered by @Coly010.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/13371689255

1 similar comment
Copy link

Failed to publish a PR release of this pull request, triggered by @Coly010.
See the failed workflow run at: https://github.com/nrwl/nx/actions/runs/13371689255

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-74361a9
Release details 📑
Published version 0.0.0-pr-29860-74361a9
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 74361a9
Workflow run 13371689255

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from eff0dd6 to e50fda7 Compare February 20, 2025 12:00
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from 9debbaf to 2cec332 Compare March 3, 2025 12:04
Copy link

github-actions bot commented Mar 3, 2025

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-2cec332
Release details 📑
Published version 0.0.0-pr-29860-2cec332
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit 2cec332
Workflow run 13632631050

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Mar 5, 2025

question: Any way to make this work with Nx 18.3 and Angular 17.3?

@LayZeeDK
Copy link
Contributor

LayZeeDK commented Mar 5, 2025

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch 2 times, most recently from 2818f1b to ba00de3 Compare March 12, 2025 13:38
@Coly010
Copy link
Contributor Author

Coly010 commented Mar 12, 2025

question: Any way to make this work with Nx 18.3 and Angular 17.3?

Currently Angular Rspack is only supporting Angular 19

Copy link

🐳 We have a release for that!

This PR has a release associated with it. You can try it out using this command:

npx [email protected] my-workspace

Or just copy this version and use it in your own command:

0.0.0-pr-29860-d639246
Release details 📑
Published version 0.0.0-pr-29860-d639246
Triggered by @Coly010
Branch angular/convert-to-rspack
Commit d639246
Workflow run 13834439518

To request a new release for this pull request, mention someone from the Nx team or the @nrwl/nx-pipelines-reviewers.

@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from d1cffbe to 0644997 Compare March 13, 2025 13:04
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from 0644997 to 923f9a6 Compare March 13, 2025 13:33
@Coly010 Coly010 marked this pull request as ready for review March 13, 2025 13:44
@Coly010 Coly010 requested review from FrozenPandaz, jaysoo, AgentEnder and a team as code owners March 13, 2025 13:44
@Coly010 Coly010 force-pushed the angular/convert-to-rspack branch from fdcf3b4 to 632966a Compare March 13, 2025 20:37
@Coly010 Coly010 enabled auto-merge (squash) March 14, 2025 16:48
@Coly010 Coly010 merged commit 0082081 into master Mar 14, 2025
12 checks passed
@Coly010 Coly010 deleted the angular/convert-to-rspack branch March 14, 2025 17:11
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants