Skip to content

refactor(sdk-trace-base): update semconv usage to ATTR_ exports #5669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2025

Conversation

trentm
Copy link
Contributor

@trentm trentm commented May 9, 2025

Refs: #4896

@trentm trentm self-assigned this May 9, 2025
@trentm trentm requested a review from a team as a code owner May 9, 2025 17:48
Copy link

codecov bot commented May 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.03%. Comparing base (bc8c94e) to head (57e40d7).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5669      +/-   ##
==========================================
- Coverage   95.03%   95.03%   -0.01%     
==========================================
  Files         310      310              
  Lines        7990     7988       -2     
  Branches     1609     1607       -2     
==========================================
- Hits         7593     7591       -2     
  Misses        397      397              
Files with missing lines Coverage Δ
packages/opentelemetry-sdk-trace-base/src/Span.ts 97.67% <100.00%> (-0.03%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@trentm trentm enabled auto-merge May 9, 2025 20:33
@trentm trentm added this pull request to the merge queue May 9, 2025
Merged via the queue into open-telemetry:main with commit d07d630 May 9, 2025
18 checks passed
@trentm trentm deleted the trentm-semconv-up-sdk-trace-base branch May 9, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants