Skip to content

feat: support after() #2717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Dec 9, 2024
Merged

feat: support after() #2717

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d5aca78
test: upgrade deno used in tests
pieh Dec 6, 2024
beec061
test: e2e simple next/after test
pieh Dec 6, 2024
e13fa25
feat: support waitUntil
ascorbic May 23, 2024
8352645
use already existing trackBackgroundWork helper from request context …
pieh Oct 21, 2024
81583b7
test: increase timeout for one of smoke tests due to team-wide extens…
pieh Dec 6, 2024
819be98
test: move test to dedicated fixture
pieh Dec 8, 2024
80de44f
chore: update outdated comment
pieh Dec 8, 2024
c938bb6
chore: clarify awaiting backgroundWorkPromise
pieh Dec 8, 2024
1a8a135
test: update assertion for next >=15.0.4-canary.18
pieh Dec 8, 2024
7217c6b
fix: support changed shape of getRequestHandlers return
pieh Dec 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: increase timeout for one of smoke tests due to team-wide extens… 
…ions installation time making it timeout
  • Loading branch information
@pieh
pieh committed Dec 6, 2024
commit 81583b7b1e34a0f7850ff3ccf1613e022811df91
10 changes: 7 additions & 3 deletions tests/smoke/deploy.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,9 +71,13 @@ describe('version check', () => {
)
},
)
test('yarn monorepo multiple next versions site is compatible', { retry: 0 }, async () => {
await smokeTest(selfCleaningFixtureFactories.yarnMonorepoMultipleNextVersionsSiteCompatible)
})
test(
'yarn monorepo multiple next versions site is compatible',
{ retry: 0, timeout: 1_000 * 60 * 5 },
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this change just bumps/sets timeout - we have 3 extensions being installed which we don't even use because site is in Netlify-testing account and that's pretty slow and this test case in particular was already slow before, but those 2 things combined meant that it was always timing out now

async () => {
await smokeTest(selfCleaningFixtureFactories.yarnMonorepoMultipleNextVersionsSiteCompatible)
},
)

test(
'yarn monorepo multiple next versions site is incompatible should not deploy',
Expand Down
Loading