Skip to content

fix: make revalidateTags no-op when list of tags is empty #2727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Dec 20, 2024
Merged

fix: make revalidateTags no-op when list of tags is empty #2727

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d7b3458
fix: make `revalidateTags` no-op when list of tags is empty
eduardoboucas Dec 18, 2024
04e5451
fix: oops
eduardoboucas Dec 18, 2024
28339a3
test: add integration test for site-wide purge calls
pieh Dec 19, 2024
d0a7f47
Merge branch 'main' into fix/noop-empty-revalidate-tags
pieh Dec 19, 2024
782a106
Merge remote-tracking branch 'origin/main' into fix/noop-empty-revali…
pieh Dec 19, 2024
f112f29
fix: filter out empty tags
pieh Dec 19, 2024
4a02e34
test: correct afterEach import
pieh Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: oops
  • Loading branch information
@eduardoboucas
eduardoboucas committed Dec 18, 2024
commit 04e54514fd9afd5a61dc4ad824aa37277efd50f9
2 changes: 1 addition & 1 deletion src/run/handlers/cache.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ export class NetlifyCacheHandler implements CacheHandlerForMultipleVersions {

getLogger().debug(`Purging CDN cache for: [${tag}]`)
requestContext.trackBackgroundWork(
purgeCache({ tags: tag.split(/,|%2c/gi) }).catch((error) => {
purgeCache({ tags }).catch((error) => {
// TODO: add reporting here
getLogger()
.withError(error)
Expand Down
Loading