Skip to content

perf: memoize blobs requests in the request scope #2777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Mar 28, 2025
Merged

perf: memoize blobs requests in the request scope #2777

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
03f168d
test: add test case with multiple fetches for same resource and test …
pieh Mar 19, 2025
2e7a951
refactor: create simplified key-value store interface to interact wit…
pieh Mar 19, 2025
2f7dee1
refactor: create reusable helper to record warnings
pieh Mar 20, 2025
85d4eb9
perf: memoize blobs requests in the request scope
pieh Mar 19, 2025
41bca90
Merge branch 'main' into michalpiechowiak/frb-1629-intermittent-proxy…
pieh Mar 26, 2025
42977ed
refactor: rename RequestSpecificInMemoryCache to RequestScopedInMemor…
pieh Mar 27, 2025
cff9f73
refactor: modulurize blobs storage abstractions
pieh Mar 27, 2025
9db4cf0
Merge remote-tracking branch 'origin/main' into michalpiechowiak/frb-…
pieh Mar 27, 2025
d2a7fac
chore: fix lint
pieh Mar 27, 2025
ca233ef
refactor: move non-CacheHandler related types and utils from cache-ty…
pieh Mar 27, 2025
578fbc5
fix: add missing implementation for isTagManifest and isHtmlBlob type…
pieh Mar 27, 2025
13a65c3
Merge branch 'main' into michalpiechowiak/frb-1629-intermittent-proxy…
pieh Mar 27, 2025
7daeeca
chore: drop use of noOpInMemoryCache
mrstork Mar 27, 2025
a1d2780
Merge branch 'main' into michalpiechowiak/frb-1629-intermittent-proxy…
pieh Mar 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: fix lint
  • Loading branch information
@pieh
pieh committed Mar 27, 2025
commit d2a7fac0a2a2674416ab60aecd84b5f710d00637
2 changes: 1 addition & 1 deletion src/run/storage/storage.cts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,8 +6,8 @@
import { type BlobType } from '../../shared/cache-types.cjs'
import { getTracer } from '../handlers/tracer.cjs'

import { getRequestSpecificInMemoryCache } from './request-scoped-in-memory-cache.cjs'
import { getRegionalBlobStore } from './regional-blob-store.cjs'
import { getRequestSpecificInMemoryCache } from './request-scoped-in-memory-cache.cjs'

const encodeBlobKey = async (key: string) => {
const { encodeBlobKey: encodeBlobKeyImpl } = await import('../../shared/blobkey.js')
Expand Down