Skip to content

Add support for safe navigation to Layout/MultilineMethodCallBraceLayout #13711

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

dvandersluis
Copy link
Member

Allows Layout/MultilineMethodCallBraceLayout to register offenses on methods called with safe navigation.


Before submitting the PR make sure the following are checked:

  • The PR relates to only one subject with a clear title and description in grammatically correct, complete sentences.
  • Wrote good commit messages.
  • Commit message starts with [Fix #issue-number] (if the related issue exists).
  • Feature branch is up-to-date with master (if not - rebase it).
  • Squashed related commits together.
  • Added tests.
  • Ran bundle exec rake default. It executes all tests and runs RuboCop on its own code.
  • Added an entry (file) to the changelog folder named {change_type}_{change_description}.md if the new code introduces user-observable changes. See changelog entry format for details.

@bbatsov bbatsov merged commit 998d1ed into rubocop:master Jan 16, 2025
23 checks passed
@bbatsov
Copy link
Collaborator

bbatsov commented Jan 16, 2025

I wonder if we'll ever get to the point where all cops are safe navigation aware... 😅 Thanks!

@dvandersluis
Copy link
Member Author

dvandersluis commented Jan 16, 2025

I'm almost at that point now! 😂

@dvandersluis dvandersluis deleted the multiline-method-call-brace-layout-safe-nav branch January 16, 2025 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants