Fix typo in openssl-sys build script #2375
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Surely the correct fix here is for cloudflare to bump the version of BoringSSL, not to make all callers carry workarounds? |
|
This problem is better known as CVE-2024-5535 |
We don't use rust-openssl. We use cloudflare/boring, I upstreamed this in case someone is using rust-openssl with an old enough boringssl commit. Feel free to decline the PR |
|
I guess the philosophy is that bindings shouldn't compensate for bugs in the underlying C/C++ library? That makes sense, I can remove the alpn commit if so. Just lmk |
|
At the very least in this specific case (BoringSSL has a "live at HEAD"
philosophy and doesn't commit to backporting security fixes, and has in
fact fixed this themselves).
…On Sun, Feb 23, 2025 at 3:40 PM Rushil Mehra ***@***.***> wrote:
I guess the philosophy is that bindings shouldn't compensate for bugs in
the underlying C/C++ library? That makes sense, I can remove the alpn
commit if so. Just lmk
—
Reply to this email directly, view it on GitHub
<#2375 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBDIMPTQWPDXOSB4BQT2RIW47AVCNFSM6AAAAABXWUGW3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGEYDKNJZGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: rushilmehra]*rushilmehra* left a comment
(sfackler/rust-openssl#2375)
<#2375 (comment)>
I guess the philosophy is that bindings shouldn't compensate for bugs in
the underlying C/C++ library? That makes sense, I can remove the alpn
commit if so. Just lmk
—
Reply to this email directly, view it on GitHub
<#2375 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAAGBDIMPTQWPDXOSB4BQT2RIW47AVCNFSM6AAAAABXWUGW3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMNZXGEYDKNJZGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
--
All that is necessary for evil to succeed is for good people to do nothing.
|
|
i.e. no need to be this overly defensive? I'll remove the commit when back at my laptop |
rushilmehra
force-pushed
the
handle-empty-alpn
branch
from
ff36410 to
d1d43ab
Compare
rushilmehra
changed the title
alex
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In older versions of boringssl (e.g. the one currently vendored in cloudflare/boring) SSL_select_next_proto doesn't properly handle the case where the supported ALPN list is empty, and it will segfault.
Offending line: https://github.com/google/boringssl/blob/44b3df6f03d85c901767250329c571db405122d5/src/ssl/ssl_lib.cc#L2221