Skip to content

Fix panic location for overlapping method routes #3319

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 24, 2025
Merged

Conversation

jplatte
Copy link
Member

@jplatte jplatte commented Apr 24, 2025

Motivation

The panic message currently points into library internals, when it should be pointing at where the user made a mistake.

Solution

Change one internal function to use Result error propagation like the rest, so the actual panicking happens inside a function that's #[track_caller].

Copy link
Collaborator

@mladedav mladedav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is really cool.

@jplatte jplatte merged commit de02bae into main Apr 24, 2025
18 checks passed
@jplatte jplatte deleted the jplatte/panic-location branch April 24, 2025 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants