Add OifIndex option for RouteGetWithOptions
#1060
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `RouteGetWithOptions` function currently has a `Oif` option which gets translated from link name to link index via a `LinkByName` call. This adds unnecessary overhead when the link index is already known. This commit adds a new `OifIndex` option to `RouteGetWithOptions` which can be specified instead of `Oif` to skip the internal link index translation. Signed-off-by: Dylan Reimerink <[email protected]>
borkmann
approved these changes
Feb 18, 2025
|
cc @aboch |
aboch
reviewed
Mar 26, 2025
| @@ -1533,6 +1533,7 @@ type RouteGetOptions struct { | |||
| Iif string | |||
| IifIndex int | |||
| Oif string | |||
| OifIndex int | |||
There was a problem hiding this comment.
I was wondering why not making this uint32 then I see IifIndex is already there as int.
LGTM
dylandreimerink
added a commit
to dylandreimerink/cilium
that referenced
this pull request
Mar 27, 2025
Update the netlink library to get vishvananda/netlink#1060 which allows us to pass a link ifindex to RouteGetWithOptions to avoid a second netlink call. Signed-off-by: Dylan Reimerink <[email protected]>
dylandreimerink
added a commit
to dylandreimerink/cilium
that referenced
this pull request
Mar 27, 2025
Update the netlink library to get vishvananda/netlink#1060 which allows us to pass a link ifindex to RouteGetWithOptions to avoid a second netlink call. Signed-off-by: Dylan Reimerink <[email protected]>
dylandreimerink
added a commit
to dylandreimerink/cilium
that referenced
this pull request
Mar 27, 2025
Update the netlink library to get vishvananda/netlink#1060 which allows us to pass a link ifindex to RouteGetWithOptions to avoid a second netlink call. Signed-off-by: Dylan Reimerink <[email protected]>
dylandreimerink
added a commit
to dylandreimerink/cilium
that referenced
this pull request
Mar 28, 2025
Update the netlink library to get vishvananda/netlink#1060 which allows us to pass a link ifindex to RouteGetWithOptions to avoid a second netlink call. Signed-off-by: Dylan Reimerink <[email protected]>
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
RouteGetWithOptionsfunction currently has aOifoption which gets translated from link name to link index via aLinkByNamecall. This adds unnecessary overhead when the link index is already known.This commit adds a new
OifIndexoption toRouteGetWithOptionswhich can be specified instead ofOifto skip the internal link index translation.