Skip to content

fix: should have correct interop for default exportsType #10069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

JSerFeng
Copy link
Contributor

Summary

fix: #10024

Should not have property access for module whose exportsType is Default

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@github-actions github-actions bot added team The issue/pr is created by the member of Rspack. release: bug fix release: bug related release(mr only) labels Apr 17, 2025
Copy link

netlify bot commented Apr 17, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit da287c1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6800bb6ebb42160008ca87fc

Copy link

codspeed-hq bot commented Apr 17, 2025

CodSpeed Performance Report

Merging #10069 will not alter performance

Comparing fix/asset-entry (da287c1) with main (ab638c0)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

@JSerFeng JSerFeng merged commit b522bfd into main Apr 18, 2025
31 checks passed
@JSerFeng JSerFeng deleted the fix/asset-entry branch April 18, 2025 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Asset entry points export undefined in ESM and library mode
2 participants