fix: comma in regex value of magic comments #10100
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
release: bug fix
✅ Deploy Preview for rspack canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This pull request fixes an issue with handling commas in regular expression values of magic comments. The changes include updating the regex pattern in WEBPACK_MAGIC_COMMENT_REGEXP to correctly handle escaped characters and commas, and adding a comprehensive test suite for various magic comment value types.
github-actions
bot
added
the
team
LingyuCoder
force-pushed
the
fix/magic-comments-regex-comma
branch
from
44767a2 to
9761081
Compare
CodSpeed Performance ReportMerging #10100 will not alter performanceComparing Summary
|
ahabhgk
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fix #7356
Checklist