Skip to content

refactor: remove dead_code and use spawn_blocking for fast_set #10151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

hardfist
Copy link
Contributor

@hardfist hardfist commented Apr 24, 2025

Summary

use spawn_blocking for fast_drop & remove dead code

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for rspack ready!

Name Link
🔨 Latest commit 91dc3bb
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6809dbda8fa9400008f4be3d
😎 Deploy Preview https://deploy-preview-10151--rspack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@github-actions github-actions bot added the team The issue/pr is created by the member of Rspack. label Apr 24, 2025
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #10151 will not alter performance

Comparing yj/remove-deadcode (91dc3bb) with main (dbdfeb1)

🎉 Hooray! codspeed-node just leveled up to 4.0.1!

A heads-up, this is a breaking change and it might affect your current performance baseline a bit. But here's the exciting part - it's packed with new, cool features and promises improved result stability 🥳!
Curious about what's new? Visit our releases page to delve into all the awesome details about this new version.

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

@quininer quininer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hardfist hardfist merged commit 4cba74c into main Apr 24, 2025
30 checks passed
@hardfist hardfist deleted the yj/remove-deadcode branch April 24, 2025 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants