Skip to content

fix: support license plugin when enable concatenated #10158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025

Conversation

LingyuCoder
Copy link
Contributor

Summary

fix #8924

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented Apr 24, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 3c9a7d1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/6809eda356256900084b4668

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request fixes the issue with the license plugin by adding support for concatenated modules and introducing a new getter for the parent module in dependencies.

  • Added a new getter "root_module" for ConcatenatedModule to obtain the root module.
  • Introduced a new getter "_parentModule" in Dependency to facilitate access to a dependency’s parent module.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
crates/node_binding/src/modules/concatenated_module.rs Added the "root_module" getter to retrieve the module that serves as the root for concatenated modules.
crates/node_binding/src/dependency.rs Added the "_parentModule" getter to expose parent module information from the dependency.

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels Apr 24, 2025
Copy link

codspeed-hq bot commented Apr 24, 2025

CodSpeed Performance Report

Merging #10158 will not alter performance

Comparing fix/license-plugin-concatenated (3c9a7d1) with main (8e906b1)

Summary

✅ 11 untouched benchmarks

@LingyuCoder LingyuCoder requested a review from JSerFeng April 24, 2025 08:25
@LingyuCoder LingyuCoder merged commit f5e46dc into main Apr 24, 2025
30 checks passed
@LingyuCoder LingyuCoder deleted the fix/license-plugin-concatenated branch April 24, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Incompatibility with webpack-license-plugin
2 participants