Skip to content

fix: simplify trace implementation by removing unused code #10325

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 11, 2025

Conversation

chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented May 11, 2025

Summary

  1. Remove entries > 0 check, because resolveLayer returns a non-empty string rather than an object.
- const entries = Object.entries(resolveLayer(filterValue));
- if (entries.length <= 0) return;
  1. Remove duplicated mkdir, it has the same function as await ensureFileDir(traceOutput);.
- await fs.promises.mkdir(defaultOutputDirname);

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

Copy link

netlify bot commented May 11, 2025

Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit dfbbad1
🔍 Latest deploy log https://app.netlify.com/sites/rspack/deploys/68209ab72ba7760008250308

@github-actions github-actions bot added release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack. labels May 11, 2025
Copy link

codspeed-hq bot commented May 11, 2025

CodSpeed Performance Report

Merging #10325 will not alter performance

Comparing simplify_trace_0511 (dfbbad1) with main (a9db9a8)

Summary

✅ 11 untouched benchmarks

@chenjiahan chenjiahan merged commit 90855cf into main May 11, 2025
35 checks passed
@chenjiahan chenjiahan deleted the simplify_trace_0511 branch May 11, 2025 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release: bug fix release: bug related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants