Skip to content

Fix shm corruption with coercion in options of unserialize() #20129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: PHP-8.3
Choose a base branch
from
+13 −4
Open

Fix shm corruption with coercion in options of unserialize() #20129

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b65954
Fix shm corruption with coercion in options of unserialize()
nielsdos Oct 10, 2025
332581e
fixup! lifetime
nielsdos Oct 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ext/standard/tests/serialize/shm_corruption_coercion_unserialize_options.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
--TEST--
Shm corruption with coercion in options of unserialize()
--FILE--
<?php
unserialize("{}", ["allowed_classes" => [0]]);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if you have a non-stringable object as an option?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That will work

Copy link
Member Author

@nielsdos nielsdos Oct 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the sense that it will throw and exit out at the check after the loop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool that's the thing I was wondering about.

?>
--EXPECTF--
Warning: unserialize(): Error at offset 0 of 2 bytes in %s on line %d
9 changes: 5 additions & 4 deletions ext/standard/var.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1366,13 +1366,14 @@ PHPAPI void php_unserialize_with_options(zval *return_value, const char *buf, co
}
if(class_hash && Z_TYPE_P(classes) == IS_ARRAY) {
zval *entry;
zend_string *lcname;

ZEND_HASH_FOREACH_VAL(Z_ARRVAL_P(classes), entry) {
convert_to_string(entry);
lcname = zend_string_tolower(Z_STR_P(entry));
/* Note: cannot use zval_get_tmp_string() here as we need to keep it in class_hash for longer than this loop. */
zend_string *str = zval_get_string(entry);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for not using the try version of this API?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible, but not necessary, as we will exit at the exception check a bit later.

zend_string *lcname = zend_string_tolower(str);
zend_hash_add_empty_element(class_hash, lcname);
zend_string_release_ex(lcname, 0);
zend_string_release_ex(lcname, false);
zend_string_release_ex(str, false);
} ZEND_HASH_FOREACH_END();

/* Exception during string conversion. */
Expand Down
Loading