strtr returns non-empty-string

[staabm]

No description provided.

[staabm]

tbh, I don't know why this test got more precise with this change :)

[ondrejmirtes]

Because preg_replace is impacted by your changes. By using selectFromArgs, conditional return type is resolved.

[staabm]

results before this PR:
https://phpstan.org/r/8833f01d-4202-4163-bf72-982f9729c3c9

[phpstan-bot]

This pull request has been marked as ready for review.

[staabm]

since strtr has multiple signatures, I had to use selectFromArgs() here.

[ondrejmirtes]

Because preg_replace is impacted by your changes. By using selectFromArgs, conditional return type is resolved.

[ondrejmirtes]

Looking at the extension, could we replace it with stubs with conditional return types instead?

[staabm]

could we replace it with stubs with conditional return types instead?

I think we could, but it would be a rather complicated conditional, which needs to cover non-empty-string, non-falsey-string and array types, and even combine those logical across parameters subject and replace.

for strtr we would also need to incorporate the 2 function variants.. I don't feel this would lead to a readable stub-file.

[ondrejmirtes]

Thank you.