Fix issue 8292 #1983
Merged
Fix issue 8292 #1983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes phpstan/phpstan#8292
All static expression types should be invalidated in anonymous/arrow functions, because the type is not reliable in delayed calls (skipped ClassConstFetch because I think it cannot change).
Also, this fixes the inconsistency between anonymous and arrow functions, which rvanvelzen mentioned in
#1929 (comment)
static expressions should be invalidate for arrows as well.
#1929 (comment)
I have a feeling that maybe we can get rid of
expressionTypeIsUnchangeableif example like#1934 (comment)
is not possible without using static expressions, but not sure enough.