Skip to content

Fix sdk module test issue #28118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

Fix sdk module test issue #28118

merged 3 commits into from
Jul 3, 2025

Conversation

vidai-msft
Copy link
Contributor

Description

This PR fixes the issue when a SDK based module had multiple test projects, PR validation only ran the .Test.
Instead all of the *.Test projects should be run

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@Copilot Copilot AI review requested due to automatic review settings July 3, 2025 02:14
Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adjusts the test project discovery in Get-CsprojFromModule to find and include all *.Test.csproj files under each module’s test directory, rather than only the <Module>.Test project. It also cleans up semicolons and standardizes some control‐flow formatting.

  • Broaden test csproj lookup via Get-ChildItem pipelines
  • Remove trailing semicolons in hashtable and return statements
  • Normalize brace placement in else blocks
Comments suppressed due to low confidence (2)

tools/BuildScripts/BuildScripts.psm1:9

  • [nitpick] Indentation for the 'Storage' entry doesn’t match the surrounding entries. Consider aligning keys consistently for readability.
        'Storage'     = @('Storage.Management')

tools/BuildScripts/BuildScripts.psm1:66

  • [nitpick] The else keyword is on its own line. For consistency with the rest of the script, consider merging } and else onto one line as } else {.
        else {

YanaXu
YanaXu previously approved these changes Jul 3, 2025
@YanaXu YanaXu enabled auto-merge (squash) July 3, 2025 02:17
@vidai-msft vidai-msft force-pushed the vidai/sdk-test-issue branch from 3025038 to 49d45f5 Compare July 3, 2025 02:19
@vidai-msft vidai-msft force-pushed the vidai/sdk-test-issue branch from 49d45f5 to 8e609aa Compare July 3, 2025 05:18
@vidai-msft vidai-msft force-pushed the vidai/sdk-test-issue branch from b032c46 to f136ba6 Compare July 3, 2025 07:11
@YanaXu YanaXu merged commit 85212eb into main Jul 3, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants