-
-
Notifications
You must be signed in to change notification settings - Fork 57
Pickup polishing (4) And Fly Camera #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dooly123
merged 9 commits into
BasisVR:working-on-avatar-UGC
from
mriise:feat/pickup-netsteal
Jun 13, 2025
Merged
Pickup polishing (4) And Fly Camera #259
dooly123
merged 9 commits into
BasisVR:working-on-avatar-UGC
from
mriise:feat/pickup-netsteal
Jun 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pickups: - better (mostly untested) handling of network pickups and stealing - max desktop zoop distance - proper velocity on drop - use direct transforms setting when Rigidbody reference is null - dont hover/interact if UI raycast had a UI target - when non-kinematic pickup disable gravity while held - only trigger OnInfluenceEnable/Disable if the value changed state InputModule: - movement, crouch, jump pause requests (temporary implementation) Camera: - fly movement - inherit from pickup to avoid repetetive code - camera pinning (handheld, playspace, world) - force camera preview to stay in front of face on desktop - lots of camera settings for cinematic style movement BasisParentConstraint: - blend quaternions better (little testing of this change done) - index gaurds
dooly123
approved these changes
Jun 11, 2025
this allows you to turn of directly the jiggles system
itsKatVR
added a commit
to itsKatVR/Basis
that referenced
this pull request
Jun 12, 2025
- rename interactDisabled to InteractableEnabled - use OnPickupDown for taking camera photos - set default interact raycast distance to 5.0 - Use new locking contexts for camera flying - Scale Camera UI based on player height (base camera object scale is 0.0003 which should be fixed at some point)
aa512ed
to
7685321
Compare
mriise
commented
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE until #258 lands or a different approach is reached.im pretty sure @dooly123 had some pickup changes that might be good to wait for to avoid conflicts.Sorry this PR isnt split better but it just so happened the things i was working on all needed changes at the same time.
Changes
Pickups:
InputModule:
movement, crouch, jump pause requests (temporary implementation, see User Input Control Improvements #258)Camera:
BasisParentConstraint:
TODO
test in vr, havent tried it at all yet.test net logicKnown Issues