Skip to content

fix: remove experimental from forked repo tests #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 13, 2025
Merged

fix: remove experimental from forked repo tests #4088

merged 26 commits into from
May 13, 2025

Conversation

davidcavazos
Copy link
Contributor

@davidcavazos davidcavazos commented May 12, 2025

Description

  • Removes (experimental) label from forked repo tests (custard-run.yaml)
  • Adds (legacy) label to old tests (custard-ci.yaml)
  • Only run legacy tests on non-forks to avoid "error noise" on fork PRs

Once we confirm everything works as expected, we can remove the legacy tests.

Checklist

  • I have followed guidelines from CONTRIBUTING.MD and Samples Style Guide
  • Tests pass: npm test (see Testing)
  • Lint pass: npm run lint (see Style)
  • These samples need a new API enabled in testing projects to pass (let us know which ones)
  • These samples need a new/updated env vars in testing projects set to pass (let us know which ones)
  • This pull request is from a branch created directly off of GoogleCloudPlatform/nodejs-docs-samples. Not a fork.
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new sample directory, and I created GitHub Actions workflow for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample
  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label bot added samples Issues that are directly related to samples. api: run Issues related to the Cloud Run API. api: workflows Issues related to the Workflows API. asset: pattern DEE Asset tagging - Pattern. labels May 12, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @davidcavazos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

This pull request addresses the labeling of tests in the repository. Specifically, it removes the '(experimental)' label from the forked repo tests (custard-run.yaml) and adds the '(legacy)' label to the old tests (custard-ci.yaml). Additionally, the PR adds a TODO comment to two files (run/helloworld/index.js and tpu/createVM.js) to trigger tests for validation.

Highlights

  • Test Labeling: The pull request updates the labels of the test files, marking the new tests as stable and the old tests as legacy.
  • Test Trigger: The pull request adds a temporary comment to trigger tests for validation purposes.

Changelog

  • run/helloworld/index.js
    • Added a TODO comment to trigger tests for validation on line 15.
  • tpu/createVM.js
    • Added a TODO comment to trigger tests for validation on line 17.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.


A label's change, a test's decree,
Legacy fades, experiments flee.
Validation's call,
A comment's thrall,
Code evolves for all to see.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request aims to remove the '(experimental)' label from forked repo tests and add a '(legacy)' label to old tests. The changes involve adding a TODO comment to two JavaScript files. Overall, the changes are straightforward.

Merge Readiness

The changes are simple and seem safe to merge. The addition of TODO comments is fine, but adding a bit more context to them would be helpful. I am unable to approve this pull request, and recommend that others review and approve this code before merging.

@davidcavazos davidcavazos marked this pull request as ready for review May 12, 2025 22:36
@davidcavazos davidcavazos requested review from a team as code owners May 12, 2025 22:36
@davidcavazos
Copy link
Contributor Author

I'm writing some documentation for contributors and reviewers on the CONTRIBUTING file.

@davidcavazos davidcavazos requested a review from a team as a code owner May 12, 2025 23:21
@davidcavazos davidcavazos merged commit 737e0eb into main May 13, 2025
15 checks passed
@davidcavazos davidcavazos deleted the fork-repos branch May 13, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: run Issues related to the Cloud Run API. api: workflows Issues related to the Workflows API. asset: pattern DEE Asset tagging - Pattern. samples Issues that are directly related to samples.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants