-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: remove experimental from forked repo tests #4088
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @davidcavazos, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses the labeling of tests in the repository. Specifically, it removes the '(experimental)' label from the forked repo tests (custard-run.yaml) and adds the '(legacy)' label to the old tests (custard-ci.yaml). Additionally, the PR adds a TODO
comment to two files (run/helloworld/index.js
and tpu/createVM.js
) to trigger tests for validation.
Highlights
- Test Labeling: The pull request updates the labels of the test files, marking the new tests as stable and the old tests as legacy.
- Test Trigger: The pull request adds a temporary comment to trigger tests for validation purposes.
Changelog
- run/helloworld/index.js
- Added a
TODO
comment to trigger tests for validation on line 15.
- Added a
- tpu/createVM.js
- Added a
TODO
comment to trigger tests for validation on line 17.
- Added a
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A label's change, a test's decree,
Legacy fades, experiments flee.
Validation's call,
A comment's thrall,
Code evolves for all to see.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request aims to remove the '(experimental)' label from forked repo tests and add a '(legacy)' label to old tests. The changes involve adding a TODO comment to two JavaScript files. Overall, the changes are straightforward.
Merge Readiness
The changes are simple and seem safe to merge. The addition of TODO comments is fine, but adding a bit more context to them would be helpful. I am unable to approve this pull request, and recommend that others review and approve this code before merging.
…cs-samples into fork-repos
…ples into fork-repos
I'm writing some documentation for contributors and reviewers on the CONTRIBUTING file. |
Co-authored-by: Katie McLaughlin <[email protected]>
…ples into fork-repos
…cs-samples into fork-repos
Description
Once we confirm everything works as expected, we can remove the legacy tests.
Checklist
npm test
(see Testing)npm run lint
(see Style)GoogleCloudPlatform/nodejs-docs-samples
. Not a fork.