Skip to content

fix: remove experimental from forked repo tests #4088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
May 13, 2025
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
d5f6c9d
feat: remove experimental from forked repo tests
davidcavazos May 12, 2025
ec9f17b
mark packages to run tests
davidcavazos May 12, 2025
8f6c2dd
mark old tests as legacy
davidcavazos May 12, 2025
a89cd1f
add more comments
davidcavazos May 12, 2025
79cadd7
add instructions to sunset old tests
davidcavazos May 12, 2025
f1d8980
rename workflow back
davidcavazos May 12, 2025
8d7235d
remove experimental from created checks
davidcavazos May 12, 2025
3694d45
Merge branch 'main' into fork-repos
davidcavazos May 12, 2025
e2e5695
Merge branch 'main' into fork-repos
davidcavazos May 12, 2025
bc1c2ba
remove packages to trigger tests
davidcavazos May 12, 2025
ef7e9ee
experiment to see if check fulfills required tests
davidcavazos May 12, 2025
dc321df
Merge branch 'fork-repos' of github.com:GoogleCloudPlatform/nodejs-do…
davidcavazos May 12, 2025
86e3151
add permissions to experiment
davidcavazos May 12, 2025
4e0815c
rename lint back
davidcavazos May 12, 2025
3f3afac
remove experiment
davidcavazos May 12, 2025
a21adc0
Merge branch 'main' of github.com:GoogleCloudPlatform/nodejs-docs-sam…
davidcavazos May 12, 2025
76955c3
only run tests on non-forks
davidcavazos May 12, 2025
4e9664b
remove experimental
davidcavazos May 12, 2025
07c8f84
document ci testing
davidcavazos May 12, 2025
25f65d7
add legacy to old dev tests
davidcavazos May 12, 2025
d8cca77
rename summary to Custard CI / test
davidcavazos May 12, 2025
e3a21e5
reorder list
davidcavazos May 12, 2025
9855d1d
Update CONTRIBUTING.md
davidcavazos May 13, 2025
2f447d2
add note to pull request template
davidcavazos May 13, 2025
a717dd9
Merge branch 'main' of github.com:GoogleCloudPlatform/nodejs-docs-sam…
davidcavazos May 13, 2025
b693de5
Merge branch 'fork-repos' of github.com:GoogleCloudPlatform/nodejs-do…
davidcavazos May 13, 2025
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only run tests on non-forks
  • Loading branch information
davidcavazos committed May 12, 2025
commit 76955c3c68bb9cd4286e7940ec9247f179d4379a
1 change: 1 addition & 0 deletions .github/workflows/custard-ci-dev.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ jobs:
echo "setups=$(./cloud-samples-tools/bin/custard setup-files .github/config/nodejs-dev.jsonc paths.txt)" >> $GITHUB_OUTPUT

nodejs-test:
if: github.event.pull_request && github.event.pull_request.head.repo.fork == false
name: test
needs: affected
runs-on: ubuntu-latest
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/custard-ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,40 +31,40 @@
# TODO: remove all jobs except region-tags (should be tested by custard-run workflows)
jobs:
affected:
name: Finding affected tests (legacy)
runs-on: ubuntu-latest
timeout-minutes: 2
outputs:
nodejs-paths: ${{ steps.nodejs.outputs.paths }}
nodejs-setups: ${{ steps.nodejs.outputs.setups }}
steps:
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
fetch-depth: 0
- uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4
with:
repository: GoogleCloudPlatform/cloud-samples-tools
ref: v0.3.2
path: cloud-samples-tools
- name: Create `bin` directory for cloud-samples-tools binaries
run: mkdir bin
working-directory: cloud-samples-tools
- uses: actions/setup-go@0aaccfd150d50ccaeb58ebd88d36e91967a5f35b # v5
with:
go-version: ${{ env.GO_VERSION }}
- name: Build Custard (from cloud-samples-tools)
run: go build -o ../bin -v ./...
working-directory: cloud-samples-tools/custard
- name: Get diffs
run: git --no-pager diff --name-only HEAD origin/main | tee diffs.txt
- name: Find Node.js affected packages
id: nodejs
run: |
echo "paths=$(./cloud-samples-tools/bin/custard affected .github/config/nodejs.jsonc diffs.txt paths.txt)" >> $GITHUB_OUTPUT
cat paths.txt
echo "setups=$(./cloud-samples-tools/bin/custard setup-files .github/config/nodejs.jsonc paths.txt)" >> $GITHUB_OUTPUT

lint:

Check warning

Code scanning / CodeQL

Workflow does not contain permissions Medium

Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {contents: read}
needs: affected
runs-on: ubuntu-latest
timeout-minutes: 5
Expand Down Expand Up @@ -122,6 +122,7 @@
- run: ./.github/workflows/utils/region-tags-tests.sh

test:
if: github.event.pull_request && github.event.pull_request.head.repo.fork == false
name: test (legacy)
needs: affected
runs-on: ubuntu-latest
Expand Down
Loading