[core] plumb table ID to flush #708
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 10, 2025
pepyakin
changed the base branch from
pep/verify-table-sizes-and-cs-digest
to
graphite-base/708
pepyakin
force-pushed
the
graphite-base/708
branch
from
1cee0f1 to
c7bf7ae
Compare
pepyakin
force-pushed
the
pep/core-add-table-id-to-flush
branch
from
54a3ab0 to
2e61f32
Compare
pepyakin
changed the base branch from
graphite-base/708
to
pep/verify-table-sizes-and-cs-digest
This was referenced Jun 11, 2025
graphite-app
bot
changed the base branch from
pep/verify-table-sizes-and-cs-digest
to
graphite-base/708
Add table ID to the `Flush` struct and prune all the flushes that reside in the empty tables. Note, that this is not possible today, as we do not include empty tables during the constraint system compilation, but we will do it later on.
pepyakin
force-pushed
the
graphite-base/708
branch
from
c7bf7ae to
2fdf679
Compare
pepyakin
force-pushed
the
pep/core-add-table-id-to-flush
branch
from
2e61f32 to
0ddab7c
Compare
djadjka
approved these changes
Jun 12, 2025
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
Jun 12, 2025
Add table ID to the `Flush` struct and prune all the flushes that reside in the empty tables. Note, that this is not possible today, as we do not include empty tables during the constraint system compilation, but we will do it later on.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add table ID to the
Flushstruct and prune all the flushes that reside in theempty tables. Note, that this is not possible today, as we do not include
empty tables during the constraint system compilation, but we will do it later
on.