[core] refactor multilinear oracle set #720
Open
+62
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 11, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
How to use the Graphite Merge QueueAdd the label merge-ready to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
pepyakin
force-pushed
the
pep/core-refactor-mos
branch
from
af692f9 to
b7cb7b7
Compare
pepyakin
force-pushed
the
pep/core-push-po2-flush-selectors
branch
2 times, most recently
from
7528f05 to
b9219b0
Compare
pepyakin
force-pushed
the
pep/core-refactor-mos
branch
from
b7cb7b7 to
2cd51d6
Compare
This refactoring just basically avoids materializing the MultilinearPolyOracle instances when they are not required. While this might be beneficial from the perf standpoint, it would also help for the sizeless version of MultilinearOracleSet.
pepyakin
force-pushed
the
pep/core-push-po2-flush-selectors
branch
from
b9219b0 to
7198717
Compare
pepyakin
force-pushed
the
pep/core-refactor-mos
branch
from
2cd51d6 to
ae89ee3
Compare
djadjka
approved these changes
Jun 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactoring just basically avoids materializing the MultilinearPolyOracle
instances when they are not required.
While this might be beneficial from the perf standpoint, it would also help for
the sizeless version of MultilinearOracleSet.