Skip to content

Remove is distance move tag #519

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025
Merged

Remove is distance move tag #519

merged 4 commits into from
Jun 5, 2025

Conversation

pw-rey
Copy link
Collaborator

@pw-rey pw-rey commented Jun 4, 2025

Thank you for your contribution to the Pokémon Studio repo.

Before submitting this PR into the develop branch, please make sure:

  • Your code builds clean without any errors or warnings
  • You are following the Code guidelines
  • You tested your code to make sure it does what it is supposed to do

Description

This PR deletes from Studio the isDistance tag that has been removed in PSDK recently. As the tag was very specifically used by moves only, it was just about deleting lines here and there.
Note: this PR doesn't come with a migration to remove this flag from the move data, as Studio can properly load a project that still contains this flag. Studio will delete the flag itself when saving any move that was changed in Studio. Whether a migration should be implemented or not to delete the flag once and for all for all moves is up to discussions.

Closes #501

Tests to perform

  • Open any 2.5.0 project with this PR: the project should correctly be loaded without any issue
  • Open the Move UI and search a move that still has the isDistance tag in its data: it should have no visual reference to this flag and the edition modal should not have the isDistance toggle
  • Search a move that does not have the isDistance tag in its data: it should not have any visual reference to this flag and the edition modal should not have the isDistance toggle
  • Edit any move, save, then check this move's data in the json: the flag must have been deleted

@pw-rey pw-rey self-assigned this Jun 4, 2025
@pw-rey pw-rey linked an issue Jun 4, 2025 that may be closed by this pull request
2 tasks
@AerunDev AerunDev merged commit c430757 into develop Jun 5, 2025
5 checks passed
@AerunDev AerunDev deleted the remove-isDistance-move-tag branch June 5, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove the isDistance move tag
5 participants