-
-
Notifications
You must be signed in to change notification settings - Fork 75
SSL auth and user GPG key support for user templates repos #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #353 +/- ##
==========================================
+ Coverage 75.66% 75.76% +0.09%
==========================================
Files 52 52
Lines 9028 9064 +36
==========================================
+ Hits 6831 6867 +36
Misses 2197 2197 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025051703-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests24 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:1 performance degradations
Remaining performance tests:15 tests
|
Generally looks good, but it could use an unit test. See test_110_qrexec_payload_refresh_success in qubesadmin/tests/tools/qvm_template.py for similar case. |
Looks like |
0da6be5
to
3658b5b
Compare
This commit adds the support of user defined GPG keys and SSL authentication for user templates repositories. GPG keys and SSL cert/key must be configured in DNF repositories files using the well-known options (gpgkey, sslclientcert, sslclientkey). If the keys are stored in /etc/qubes/repo-templates/keys/, they will be added to the payload sent to proxy in base64 and will be written to the Proxy VM before DNF command execution
This commit adds the support of user defined GPG keys and SSL authentication for user templates repositories.
GPG keys and SSL cert/key must be configured in DNF repositories files using the well-known options
(gpgkey, sslclientcert, sslclientkey).
If the keys are stored in /etc/qubes/repo-templates/keys/, they will be added to the payload sent to proxy in base64 and will be written to the Proxy VM before DNF command execution
QubesOS/qubes-issues#9850