Assure backup restore/verify tmpdir is properly deleted #351
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #351 +/- ##
==========================================
+ Coverage 75.80% 75.83% +0.03%
==========================================
Files 52 52
Lines 9080 9084 +4
==========================================
+ Hits 6883 6889 +6
+ Misses 2197 2195 -2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
OpenQA test summaryComplete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025052321-4.3&flavor=pull-requests Test run included the following:
New failures, excluding unstableCompared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update
Failed tests18 failures
Fixed failuresCompared to: https://openqa.qubes-os.org/tests/132953#dependencies 14 fixed
Unstable tests
Performance TestsPerformance degradation:15 performance degradations
Remaining performance tests:41 tests
|
alimirjamali
force-pushed
the
issue-9387-restore-tmp-files
branch
from
0bb14de to
08f6820
Compare
The temporary directories remain when either: - The operation is cancelled at the summary screen (before actually starting restore/verify) - The operation fails early in the `restore_do` function. For example in `check_disk_space` or `_restore_vms_metadata`. Since deleting tmp directory in `restore_do` does not work properly (this is confirmed by the unittests), we check for its existence again once more in `__del__` destructor and delete it if it still exists. fixes: QubesOS/qubes-issues#9387
alimirjamali
force-pushed
the
issue-9387-restore-tmp-files
branch
from
08f6820 to
abd1c6d
Compare
fixes: QubesOS/qubes-issues#9387