Allow qubes-dom0-update --action=download

[alimirjamali]

resolves: QubesOS/qubes-issues#9958

[marmarek]

PipelineRetry

[alimirjamali]

PipelineRetryFailed

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.68%. Comparing base (4fb6c15) to head (ee9ead5).
Report is 5 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #572      +/-   ##
==========================================
- Coverage   71.10%   70.68%   -0.42%     
==========================================
  Files           3        3              
  Lines         481      481              
==========================================
- Hits          342      340       -2     
- Misses        139      141       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[qubesos-bot]

OpenQA test summary

Complete test suite and dependencies: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025051823-4.3&flavor=pull-requests

Test run included the following:

• Ignore RemoteVM for now qubes-manager#398 (QubesOS/qubes-manager@679eff4)
• Wait for session only if necessary #571 (397ffc9)
• merge_tops : throw better error if top is invalid qubes-mgmt-salt-base-topd#15 (QubesOS/qubes-mgmt-salt-base-topd@44d09b1)
• Add Arch packaging qubes-core-admin-client#332 (QubesOS/qubes-core-admin-client@e22c531)
• Assure backup restore/verify tmpdir is properly deleted qubes-core-admin-client#351 (QubesOS/qubes-core-admin-client@08f6820)
• Restart qrexec-agent on update qubes-core-qrexec#205 (QubesOS/qubes-core-qrexec@27facce)
• Correctly label pointing device as absolute, not relative qubes-gui-agent-linux#228 (QubesOS/qubes-gui-agent-linux@5947c79)
• Disable (in updatevm) dnf ANSI coloring of output #573 (9f99162)
• Allow qubes-dom0-update --action=download #572 (ee9ead5)
• Redefine DeviceCategories and improvements in MockDevices qubes-core-admin-client#355 (QubesOS/qubes-core-admin-client@9308882)
• Devel20250429 qubes-ansible#7 (QubesOS/qubes-ansible@62a9741)
• Make Devices tab prettier & safer qubes-manager#421 (QubesOS/qubes-manager@2bed45c)
• Don't translate dom0 to @adminvm qubes-core-qrexec#204 (QubesOS/qubes-core-qrexec@4d62b9e)
• SSL auth and user GPG key support for user templates repos #570 (6868158)
• Device API changes qubes-desktop-linux-manager#258 (QubesOS/qubes-desktop-linux-manager@af1eb3e)
• Allow user to save valid modified policy on 1st char qubes-desktop-linux-manager#256 (QubesOS/qubes-desktop-linux-manager@be1f977)
• Fix handling remove event qubes-app-linux-input-proxy#38 (QubesOS/qubes-app-linux-input-proxy@45a7c06)
• Fix tests for changes in mock API qubes-manager#423 (QubesOS/qubes-manager@7192b9a)
• Improve qvm-backup-restore --paranoid-mode qubes-core-admin-client#358 (QubesOS/qubes-core-admin-client@302533f)

New failures, excluding unstable

Compared to: https://openqa.qubes-os.org/tests/overview?distri=qubesos&version=4.3&build=2025031804-4.3&flavor=update

• system_tests_whonix

  • whonix_torbrowser: unnamed test (unknown)
  • whonix_torbrowser: Failed (test died)
    # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...

• system_tests_gui_tools

  • desktop_linux_manager_config: unnamed test (unknown)
  • desktop_linux_manager_config: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-global-config' ...

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_qwt_win10_seamless@hw13

  • windows_clipboard_and_filecopy: unnamed test (unknown)
  • windows_clipboard_and_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'windows-Edge-address-...

• system_tests_qwt_win11@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/dcWzE-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• install_default_upload@hw7

  • install_startup: unnamed test (unknown)
  • install_startup: Failed (test died)
    # Test died: no candidate needle with tag(s) 'installer' matched...

Failed tests

12 failures

• system_tests_whonix

  • whonix_torbrowser: unnamed test (unknown)
  • whonix_torbrowser: Failed (test died)
    # Test died: no candidate needle with tag(s) 'anon-whonix-tor-brows...

• system_tests_gui_tools

  • desktop_linux_manager_config: unnamed test (unknown)
  • desktop_linux_manager_config: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-global-config' ...

• system_tests_kde_gui_interactive

  • gui_keyboard_layout: wait_serial (wait serial expected)
    # wait_serial expected: "echo -e '[Layout]\nLayoutList=us,de' | sud...

  • gui_keyboard_layout: Failed (test died)
    # Test died: command 'test "$(cd ~user;ls e1*)" = "$(qvm-run -p wor...

• system_tests_qwt_win10_seamless@hw13

  • windows_clipboard_and_filecopy: unnamed test (unknown)
  • windows_clipboard_and_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'windows-Edge-address-...

• system_tests_qwt_win11@hw13

  • windows_install: wait_serial (wait serial expected)
    # wait_serial expected: qr/dcWzE-\d+-/...

  • windows_install: Failed (test died + timed out)
    # Test died: command 'script -e -c 'bash -x /usr/bin/qvm-create-win...

• install_default_upload@hw7

  • install_startup: unnamed test (unknown)
  • install_startup: Failed (test died)
    # Test died: no candidate needle with tag(s) 'installer' matched...

Fixed failures

Compared to: https://openqa.qubes-os.org/tests/132953#dependencies

14 fixed

• system_tests_whonix

  • whonixcheck: fail (unknown)
    Whonixcheck for sys-whonix failed...

  • whonixcheck: unnamed test (unknown)

• system_tests_suspend

  • suspend: unnamed test (unknown)
  • suspend: Failed (test died)
    # Test died: no candidate needle with tag(s) 'SUSPEND-FAILED' match...

• system_tests_basic_vm_qrexec_gui

  • TC_20_NonAudio_whonix-gateway-17: test_300_bug_1028_gui_memory_pinning (failure)
    AssertionError: Dom0 window doesn't match VM window content, saved ...

• system_tests_qrexec

  • TC_00_Qrexec_fedora-41-xfce: test_081_qrexec_service_argument_allow_specific (error)
    subprocess.CalledProcessError: Command '/usr/lib/qubes/qrexec-clien...

• system_tests_kde_gui_interactive

  • clipboard_and_web: unnamed test (unknown)

  • clipboard_and_web: Failed (test died)
    # Test died: no candidate needle with tag(s) 'qubes-website' matche...

  • clipboard_and_web: wait_serial (wait serial expected)
    # wait_serial expected: "lspci; echo 2E8vz-\$?-"...

• system_tests_guivm_vnc_gui_interactive

  • gui_filecopy: unnamed test (unknown)
  • gui_filecopy: Failed (test died)
    # Test died: no candidate needle with tag(s) 'files-work' matched...

• system_tests_audio

  • TC_20_AudioVM_Pulse_whonix-workstation-17: test_252_audio_playback_audiovm_switch_hvm (failure)
    AssertionError: only silence detected, no useful audio data

• system_tests_whonix@hw7

  • whonixcheck: fail (unknown)
    Whonixcheck for sys-whonix failed...

  • whonixcheck: unnamed test (unknown)

Unstable tests

• system_tests_update

  update2/Failed (1/5 times with errors)

  • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

• system_tests_update@hw1

  update2/Failed (1/5 times with errors)

  • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

• system_tests_update@hw13

  update2/Failed (1/5 times with errors)

  • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

• system_tests_update@hw7

  update2/Failed (1/5 times with errors)

  • job 139051 # Test died: command 'script -c 'qubes-vm-update --force-update --l...

Performance Tests

Performance degradation:

14 performance degradations

• debian-12-xfce_exec: 8.30 :small_red_triangle_up: ( previous job: 7.12, degradation: 116.60%)
• debian-12-xfce_exec-data-duplex: 77.38 :small_red_triangle_up: ( previous job: 70.34, degradation: 110.00%)
• dom0_root_seq1m_q8t1_read 3:read_bandwidth_kb: 286888.00 :small_red_triangle_up: ( previous job: 446963.00, degradation: 64.19%)
• dom0_varlibqubes_seq1m_q8t1_write 3:write_bandwidth_kb: 205043.00 :small_red_triangle_up: ( previous job: 250795.00, degradation: 81.76%)
• dom0_varlibqubes_rnd4k_q1t1_write 3:write_bandwidth_kb: 3562.00 :small_red_triangle_up: ( previous job: 4903.00, degradation: 72.65%)
• fedora-41-xfce_root_seq1m_q8t1_write 3:write_bandwidth_kb: 122998.00 :small_red_triangle_up: ( previous job: 162081.00, degradation: 75.89%)
• fedora-41-xfce_root_seq1m_q1t1_read 3:read_bandwidth_kb: 282711.00 :small_red_triangle_up: ( previous job: 318716.00, degradation: 88.70%)
• fedora-41-xfce_root_seq1m_q1t1_write 3:write_bandwidth_kb: 45134.00 :small_red_triangle_up: ( previous job: 87940.00, degradation: 51.32%)
• fedora-41-xfce_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 2720.00 :small_red_triangle_up: ( previous job: 3599.00, degradation: 75.58%)
• fedora-41-xfce_private_seq1m_q8t1_write 3:write_bandwidth_kb: 74605.00 :small_red_triangle_up: ( previous job: 170062.00, degradation: 43.87%)
• fedora-41-xfce_private_rnd4k_q1t1_write 3:write_bandwidth_kb: 978.00 :small_red_triangle_up: ( previous job: 1130.00, degradation: 86.55%)
• fedora-41-xfce_volatile_seq1m_q8t1_write 3:write_bandwidth_kb: 131747.00 :small_red_triangle_up: ( previous job: 179949.00, degradation: 73.21%)
• fedora-41-xfce_volatile_rnd4k_q32t1_write 3:write_bandwidth_kb: 3139.00 :small_red_triangle_up: ( previous job: 5672.00, degradation: 55.34%)
• fedora-41-xfce_volatile_rnd4k_q1t1_write 3:write_bandwidth_kb: 1199.00 :small_red_triangle_up: ( previous job: 1953.00, degradation: 61.39%)

Remaining performance tests:

42 tests

• debian-12-xfce_exec-root: 29.02 :small_red_triangle_up: ( previous job: 28.65, degradation: 101.26%)
• debian-12-xfce_socket: 8.68 :small_red_triangle_up: ( previous job: 8.60, degradation: 100.95%)
• debian-12-xfce_socket-root: 8.68 :small_red_triangle_up: ( previous job: 8.52, degradation: 101.77%)
• debian-12-xfce_exec-data-simplex: 71.97 :small_red_triangle_up: ( previous job: 71.62, degradation: 100.48%)
• debian-12-xfce_exec-data-duplex-root: 88.66 :small_red_triangle_up: ( previous job: 82.72, degradation: 107.18%)
• debian-12-xfce_socket-data-duplex: 166.31 :small_red_triangle_up: ( previous job: 156.96, degradation: 105.96%)
• fedora-41-xfce_exec: 9.22 🟢 ( previous job: 9.27, improvement: 99.54%)
• fedora-41-xfce_exec-root: 60.24 🟢 ( previous job: 61.51, improvement: 97.93%)
• fedora-41-xfce_socket: 8.20 🟢 ( previous job: 8.63, improvement: 94.98%)
• fedora-41-xfce_socket-root: 8.50 🟢 ( previous job: 8.71, improvement: 97.66%)
• fedora-41-xfce_exec-data-simplex: 62.74 🟢 ( previous job: 75.53, improvement: 83.06%)
• fedora-41-xfce_exec-data-duplex: 71.60 :small_red_triangle_up: ( previous job: 71.56, degradation: 100.05%)
• fedora-41-xfce_exec-data-duplex-root: 95.13 🟢 ( previous job: 109.13, improvement: 87.17%)
• fedora-41-xfce_socket-data-duplex: 152.58 :small_red_triangle_up: ( previous job: 150.61, degradation: 101.31%)
• dom0_root_seq1m_q8t1_write 3:write_bandwidth_kb: 213733.00 :green_circle: ( previous job: 129298.00, improvement: 165.30%)
• dom0_root_seq1m_q1t1_read 3:read_bandwidth_kb: 277474.00 :small_red_triangle_up: ( previous job: 294295.00, degradation: 94.28%)
• dom0_root_seq1m_q1t1_write 3:write_bandwidth_kb: 121432.00 :green_circle: ( previous job: 95454.00, improvement: 127.22%)
• dom0_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 94436.00 :green_circle: ( previous job: 79803.00, improvement: 118.34%)
• dom0_root_rnd4k_q32t1_write 3:write_bandwidth_kb: 7148.00 :green_circle: ( previous job: 6149.00, improvement: 116.25%)
• dom0_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 10834.00 :green_circle: ( previous job: 10795.00, improvement: 100.36%)
• dom0_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 5053.00 :green_circle: ( previous job: 4826.00, improvement: 104.70%)
• dom0_varlibqubes_seq1m_q8t1_read 3:read_bandwidth_kb: 463356.00 :green_circle: ( previous job: 382273.00, improvement: 121.21%)
• dom0_varlibqubes_seq1m_q1t1_read 3:read_bandwidth_kb: 438184.00 :green_circle: ( previous job: 437636.00, improvement: 100.13%)
• dom0_varlibqubes_seq1m_q1t1_write 3:write_bandwidth_kb: 174889.00 :small_red_triangle_up: ( previous job: 184752.00, degradation: 94.66%)
• dom0_varlibqubes_rnd4k_q32t1_read 3:read_bandwidth_kb: 107526.00 :green_circle: ( previous job: 62195.00, improvement: 172.89%)
• dom0_varlibqubes_rnd4k_q32t1_write 3:write_bandwidth_kb: 8952.00 :green_circle: ( previous job: 6479.00, improvement: 138.17%)
• dom0_varlibqubes_rnd4k_q1t1_read 3:read_bandwidth_kb: 8290.00 :green_circle: ( previous job: 7669.00, improvement: 108.10%)
• fedora-41-xfce_root_seq1m_q8t1_read 3:read_bandwidth_kb: 369607.00 :green_circle: ( previous job: 368309.00, improvement: 100.35%)
• fedora-41-xfce_root_rnd4k_q32t1_read 3:read_bandwidth_kb: 78056.00 :small_red_triangle_up: ( previous job: 82694.00, degradation: 94.39%)
• fedora-41-xfce_root_rnd4k_q1t1_read 3:read_bandwidth_kb: 9160.00 :green_circle: ( previous job: 8485.00, improvement: 107.96%)
• fedora-41-xfce_root_rnd4k_q1t1_write 3:write_bandwidth_kb: 1136.00 :green_circle: ( previous job: 542.00, improvement: 209.59%)
• fedora-41-xfce_private_seq1m_q8t1_read 3:read_bandwidth_kb: 356294.00 :small_red_triangle_up: ( previous job: 373957.00, degradation: 95.28%)
• fedora-41-xfce_private_seq1m_q1t1_read 3:read_bandwidth_kb: 333941.00 :small_red_triangle_up: ( previous job: 334687.00, degradation: 99.78%)
• fedora-41-xfce_private_seq1m_q1t1_write 3:write_bandwidth_kb: 94856.00 :green_circle: ( previous job: 61534.00, improvement: 154.15%)
• fedora-41-xfce_private_rnd4k_q32t1_read 3:read_bandwidth_kb: 76397.00 :small_red_triangle_up: ( previous job: 80283.00, degradation: 95.16%)
• fedora-41-xfce_private_rnd4k_q32t1_write 3:write_bandwidth_kb: 2572.00 :green_circle: ( previous job: 2215.00, improvement: 116.12%)
• fedora-41-xfce_private_rnd4k_q1t1_read 3:read_bandwidth_kb: 7678.00 :green_circle: ( previous job: 7540.00, improvement: 101.83%)
• fedora-41-xfce_volatile_seq1m_q8t1_read 3:read_bandwidth_kb: 356173.00 :small_red_triangle_up: ( previous job: 369868.00, degradation: 96.30%)
• fedora-41-xfce_volatile_seq1m_q1t1_read 3:read_bandwidth_kb: 301748.00 :small_red_triangle_up: ( previous job: 324737.00, degradation: 92.92%)
• fedora-41-xfce_volatile_seq1m_q1t1_write 3:write_bandwidth_kb: 74792.00 :green_circle: ( previous job: 17567.00, improvement: 425.75%)
• fedora-41-xfce_volatile_rnd4k_q32t1_read 3:read_bandwidth_kb: 83512.00 :green_circle: ( previous job: 79021.00, improvement: 105.68%)
• fedora-41-xfce_volatile_rnd4k_q1t1_read 3:read_bandwidth_kb: 8461.00 :green_circle: ( previous job: 7867.00, improvement: 107.55%)