-
Notifications
You must be signed in to change notification settings - Fork 45
refactor(bincode,misc,style): refine some bincode for stricter typing and column limit #740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
InKryption
wants to merge
2
commits into
main
Choose a base branch
from
ink/bincode-refinements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 16, 2025
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAttention: Patch coverage is
🚀 New features to boost your workflow:
|
f7a7226
to
4423f75
Compare
f5c04b2
to
350afb3
Compare
4423f75
to
bc7d913
Compare
bc7d913
to
ac49b2a
Compare
350afb3
to
9928b01
Compare
ac49b2a
to
c06520c
Compare
d5c0838
to
4f8b4ac
Compare
56ba8a2
to
d2a5d0c
Compare
4f8b4ac
to
1b36422
Compare
1b36422
to
dec42a3
Compare
d2a5d0c
to
9592b4e
Compare
dec42a3
to
9d4ab1e
Compare
9592b4e
to
f5044f9
Compare
Rexicon226
requested changes
May 28, 2025
f5044f9
to
b7b82df
Compare
9d4ab1e
to
00c3181
Compare
Rexicon226
previously approved these changes
May 28, 2025
00c3181
to
b1f2fb2
Compare
Rexicon226
approved these changes
May 28, 2025
b1f2fb2
to
761c4b5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: turns out, it seems to not matter that the
FieldConfig
's function fields are of typeanyerror
, the compiler seems to be capable of understanding their concrete error set based on the function body value assigned to them, making all of theanyerror
error set annotations entirely unnecessary - I originally thought it would require a deeper re-design to be rid ofanyerror
here, so that's a welcome discovery.