Skip to content

refactor(bincode,misc,style): refine some bincode for stricter typing and column limit #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

InKryption
Copy link
Contributor

@InKryption InKryption commented May 16, 2025

Edit: turns out, it seems to not matter that the FieldConfig's function fields are of type anyerror, the compiler seems to be capable of understanding their concrete error set based on the function body value assigned to them, making all of the anyerror error set annotations entirely unnecessary - I originally thought it would require a deeper re-design to be rid of anyerror here, so that's a welcome discovery.

Copy link
Contributor Author

InKryption commented May 16, 2025

Copy link

codecov bot commented May 16, 2025

Codecov Report

Attention: Patch coverage is 86.20690% with 16 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/bincode/bincode.zig 77.35% 12 Missing ⚠️
src/gossip/data.zig 20.00% 4 Missing ⚠️
Files with missing lines Coverage Δ
src/accountsdb/buffer_pool.zig 96.19% <100.00%> (ø)
src/accountsdb/snapshots.zig 91.01% <100.00%> (ø)
src/bincode/arraylist.zig 96.29% <100.00%> (+0.64%) ⬆️
src/bincode/hashmap.zig 96.66% <100.00%> (ø)
src/bincode/int.zig 96.29% <100.00%> (+1.17%) ⬆️
src/bincode/shortvec.zig 94.11% <100.00%> (ø)
src/bincode/varint.zig 82.45% <100.00%> (-0.31%) ⬇️
src/bloom/bit_vec.zig 100.00% <100.00%> (ø)
src/ledger/shred.zig 92.09% <100.00%> (ø)
src/gossip/data.zig 74.54% <20.00%> (ø)
... and 1 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@InKryption InKryption changed the title Refine some bincode type stuff and style things refactor(bincode,misc,style): refine some bincode for stricter typing and column limit May 16, 2025
@InKryption InKryption marked this pull request as ready for review May 16, 2025 14:05
@InKryption InKryption self-assigned this May 16, 2025
@InKryption InKryption requested a review from Rexicon226 May 16, 2025 14:09
@InKryption InKryption force-pushed the ink/bounded-pubkey-seed branch from f7a7226 to 4423f75 Compare May 22, 2025 13:52
@InKryption InKryption force-pushed the ink/bincode-refinements branch 2 times, most recently from f5c04b2 to 350afb3 Compare May 22, 2025 19:13
@InKryption InKryption force-pushed the ink/bounded-pubkey-seed branch from 4423f75 to bc7d913 Compare May 22, 2025 19:13
@InKryption InKryption force-pushed the ink/bounded-pubkey-seed branch from bc7d913 to ac49b2a Compare May 24, 2025 20:03
@InKryption InKryption force-pushed the ink/bincode-refinements branch from 350afb3 to 9928b01 Compare May 24, 2025 20:03
@InKryption InKryption force-pushed the ink/bounded-pubkey-seed branch from ac49b2a to c06520c Compare May 25, 2025 10:16
@InKryption InKryption force-pushed the ink/bincode-refinements branch 3 times, most recently from d5c0838 to 4f8b4ac Compare May 27, 2025 17:05
@InKryption InKryption force-pushed the ink/bounded-pubkey-seed branch 2 times, most recently from 56ba8a2 to d2a5d0c Compare May 28, 2025 15:54
@InKryption InKryption force-pushed the ink/bincode-refinements branch from 4f8b4ac to 1b36422 Compare May 28, 2025 15:54
@InKryption InKryption changed the base branch from ink/bounded-pubkey-seed to graphite-base/740 May 28, 2025 15:55
@InKryption InKryption changed the base branch from graphite-base/740 to ink/system-instruction-deinit May 28, 2025 15:57
@InKryption InKryption force-pushed the ink/bincode-refinements branch from 1b36422 to dec42a3 Compare May 28, 2025 18:10
@InKryption InKryption force-pushed the ink/system-instruction-deinit branch from d2a5d0c to 9592b4e Compare May 28, 2025 18:10
@InKryption InKryption force-pushed the ink/bincode-refinements branch from dec42a3 to 9d4ab1e Compare May 28, 2025 18:29
@InKryption InKryption force-pushed the ink/system-instruction-deinit branch from 9592b4e to f5044f9 Compare May 28, 2025 18:29
@github-project-automation github-project-automation bot moved this from 🏗 In progress to 👀 In review in Sig May 28, 2025
@InKryption InKryption force-pushed the ink/system-instruction-deinit branch from f5044f9 to b7b82df Compare May 28, 2025 20:14
@InKryption InKryption force-pushed the ink/bincode-refinements branch from 9d4ab1e to 00c3181 Compare May 28, 2025 20:14
Rexicon226
Rexicon226 previously approved these changes May 28, 2025
Base automatically changed from ink/system-instruction-deinit to main May 28, 2025 21:54
@InKryption InKryption dismissed Rexicon226’s stale review May 28, 2025 21:54

The base branch was changed.

@InKryption InKryption force-pushed the ink/bincode-refinements branch from 00c3181 to b1f2fb2 Compare May 28, 2025 21:56
@InKryption InKryption enabled auto-merge May 28, 2025 21:56
@InKryption InKryption requested a review from Rexicon226 May 28, 2025 21:56
@InKryption InKryption requested a review from yewman May 28, 2025 22:27
@InKryption InKryption force-pushed the ink/bincode-refinements branch from b1f2fb2 to 761c4b5 Compare June 3, 2025 17:44
@InKryption InKryption requested review from ultd and dnut as code owners June 3, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

2 participants