Skip to content

Update minimum required CMake version to 3.5 #717

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2025

Conversation

hyperupcall
Copy link
Contributor

@hyperupcall hyperupcall commented May 9, 2025

When building AppImageLauncher, I came across the error:

CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.

The error shows when I use CMake v4.0.2, but not when I switch back to v3.31.7. Updating the minimum version to 3.5 fixed the issue for me.

I have also made a PR for AppImageUpdate.

@hyperupcall hyperupcall changed the title Update minimum required cmake version to 3.5 Update minimum required CMake version to 3.5 May 9, 2025
@trinitronx
Copy link

trinitronx commented May 23, 2025

I can verify that this also affects the ArchLinux aur/appimagelauncher-git package (version: r1329.3d42d4c-2)

$ yay -Syu --sudoloop

[...SNIP...]

==> Making package: appimagelauncher-git r1329.3d42d4c-2 (Fri 23 May 2025 02:27:48 PM MDT)
==> Checking runtime dependencies...
==> Checking buildtime dependencies...
==> WARNING: Using existing $srcdir/ tree
==> Starting pkgver()...
==> Starting build()...
CMake Error at CMakeLists.txt:1 (cmake_minimum_required):
  Compatibility with CMake < 3.5 has been removed from CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

  Or, add -DCMAKE_POLICY_VERSION_MINIMUM=3.5 to try configuring anyway.


-- Configuring incomplete, errors occurred!
==> ERROR: A failure occurred in build().
    Aborting...
 -> error making: appimagelauncher-git-exit status 4

cc: @FabioLolix

Note: This still depends on AppImageCommunity/AppImageUpdate@673af3cbe79f and needs this version be updated.

It will also need one more change to update CMake min version here

@TheAssassin
Copy link
Owner

Thanks!

@TheAssassin TheAssassin enabled auto-merge (rebase) May 23, 2025 22:03
@TheAssassin TheAssassin merged commit d91fef4 into TheAssassin:master May 23, 2025
7 checks passed
@trinitronx
Copy link

Also seems CMake version needs to be updated in a few more sub-dependencies:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants