Skip to content

Fix flakey test_uvloop_secure_https_proxy test #10907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 20, 2025
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 20, 2025

This is another attempt to fix this flakey test. Sadly it only fails in the CI, and only sometimes

This is another attempt to fix this flakey test
@bdraco bdraco added bot:chronographer:skip This PR does not need to include a change note backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot labels May 20, 2025
@bdraco bdraco marked this pull request as ready for review May 20, 2025 20:29
@bdraco bdraco requested a review from asvetlov as a code owner May 20, 2025 20:29
@bdraco bdraco enabled auto-merge (squash) May 20, 2025 20:29
Copy link

codecov bot commented May 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.75%. Comparing base (4624fed) to head (6f18f7e).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10907      +/-   ##
==========================================
+ Coverage   97.58%   98.75%   +1.17%     
==========================================
  Files         127      129       +2     
  Lines       39031    39099      +68     
  Branches     2155     2166      +11     
==========================================
+ Hits        38088    38613     +525     
+ Misses        776      337     -439     
+ Partials      167      149      -18     
Flag Coverage Δ
CI-GHA 98.64% <100.00%> (+1.14%) ⬆️
OS-Linux 98.35% <100.00%> (?)
OS-Windows 96.50% <0.00%> (?)
OS-macOS 97.50% <100.00%> (+0.01%) ⬆️
Py-3.10.11 97.39% <100.00%> (?)
Py-3.10.17 97.92% <100.00%> (?)
Py-3.11.12 98.00% <100.00%> (?)
Py-3.11.9 97.47% <100.00%> (+0.30%) ⬆️
Py-3.12.10 98.42% <100.00%> (+1.13%) ⬆️
Py-3.13.3 98.40% <100.00%> (+1.11%) ⬆️
Py-3.9.13 97.26% <100.00%> (+0.29%) ⬆️
Py-3.9.22 97.79% <100.00%> (?)
Py-pypy7.3.16 86.55% <0.00%> (?)
VM-macos 97.50% <100.00%> (+0.01%) ⬆️
VM-ubuntu 98.35% <100.00%> (?)
VM-windows 96.50% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

codspeed-hq bot commented May 20, 2025

CodSpeed Performance Report

Merging #10907 will not alter performance

Comparing uvloop_proxy_test (6f18f7e) with master (4624fed)

Summary

✅ 60 untouched benchmarks

@bdraco bdraco merged commit b25eca0 into master May 20, 2025
43 checks passed
@bdraco bdraco deleted the uvloop_proxy_test branch May 20, 2025 20:36
Copy link
Contributor

patchback bot commented May 20, 2025

Backport to 3.11: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.11/b25eca0144e618a91b78c3b0f348503db2510657/pr-10907

Backported as #10908

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Copy link
Contributor

patchback bot commented May 20, 2025

Backport to 3.12: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.12/b25eca0144e618a91b78c3b0f348503db2510657/pr-10907

Backported as #10909

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request May 20, 2025
bdraco added a commit that referenced this pull request May 20, 2025
bdraco added a commit that referenced this pull request May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.11 Trigger automatic backporting to the 3.11 release branch by Patchback robot backport-3.12 Trigger automatic backporting to the 3.12 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant